Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "npm run" instead of "node ./cli.js" in CONTRIBUTING.md #4033

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Use "npm run" instead of "node ./cli.js" in CONTRIBUTING.md #4033

merged 1 commit into from
Aug 30, 2024

Conversation

Vampire
Copy link
Contributor

@Vampire Vampire commented Aug 29, 2024

No description provided.

@github-actions github-actions bot added the documentation "**/*.md" folder is updated (auto-generated by labeler action) label Aug 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@Vampire Vampire mentioned this pull request Aug 29, 2024
Merged
@madskristensen madskristensen merged commit 8d2596c into SchemaStore:master Aug 30, 2024
4 checks passed
@madskristensen
Copy link
Contributor

Thanks

@Vampire Vampire deleted the npm-run branch August 30, 2024 17:56
hyperupcall added a commit that referenced this pull request Aug 30, 2024
@hyperupcall
Revert "Use "npm run" instead of "node ./cli.js" in CONTRIBUTING.md (#…
c6ce28d 
…4033)"

This reverts commit 8d2596c.
@hyperupcall hyperupcall mentioned this pull request Aug 30, 2024
Merged
@hyperupcall
Copy link
Member

hyperupcall commented Aug 30, 2024 •
edited
Loading

Thanks but I wrote the original instructions because in my opinion they are better for new contributors. I reverted this in #4040

@Vampire
Copy link
Contributor Author

Vampire commented Aug 31, 2024

Maybe you should then also change the npm run new-schema and the npm run check-strict if it stays?
Now it is inconsistent again :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madskristensen madskristensen Awaiting requested review from madskristensen madskristensen is a code owner

@hyperupcall hyperupcall Awaiting requested review from hyperupcall hyperupcall is a code owner

Assignees
No one assigned
Labels
documentation "**/*.md" folder is updated (auto-generated by labeler action)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vampire @madskristensen @hyperupcall