golangci-lint: use external JSON schema #3634
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
ldez
force-pushed
the
feat/update-golangci-lint
branch
from
351eb9e to
2b5fe29
Compare
|
Thanks for the contribution - this patchset is backwards incompatible as it will break consumers that use the schemastore URL directly. Could you follow these instructions to make this change in a backwards-compatible way? |
ldez
force-pushed
the
feat/update-golangci-lint
branch
from
f639721 to
8be6d77
Compare
|
I was expecting that the store would be a proxy, so we will change our URLs because I think that relying on GitHub and a specific branch is not a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now host our schema for easing the maintenance.
golangci/golangci-lint#4487