Fix margin and padding in block.json#1903
Merged
madskristensen merged 2 commits intoSchemaStore:masterfrom Oct 25, 2021
Merged
Conversation
Merged enums in margin and padding since they can be used together according to WordPress/gutenberg#31774
This was referenced Oct 25, 2021
fabiankaegy
suggested changes
Oct 25, 2021
Contributor
There was a problem hiding this comment.
@ajlende As far as I understand it from the handbook it can either be
boolean- any combination of:
topleftrightbottom - any combination of:
horizontalvertical
The change you made would not throw an error when top and vertical are mixed
That is at least based on the documentation here: https://developer.wordpress.org/block-editor/reference-guides/block-api/block-supports/#spacing
oandregal
reviewed
Oct 25, 2021
fabiankaegy
approved these changes
Oct 25, 2021
Contributor
fabiankaegy
left a comment
fabiankaegy
left a comment
There was a problem hiding this comment.
Looks good to me (y)
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged enums in margin and padding since they can be used together according to WordPress/gutenberg#31774