Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisableRollback not fully implemented in stack updates #1493

Closed
alex-harvey-z3q opened this issue Aug 3, 2024 · 0 comments
Closed

DisableRollback not fully implemented in stack updates #1493

alex-harvey-z3q opened this issue Aug 3, 2024 · 0 comments
Assignees

Comments

@alex-harvey-z3q
Copy link
Contributor

Subject of the issue

DisableRollback is handled only during the creation of a stack and not for stack updates. This appears to be an oversight. It is already half-implemented in the CLI.

Your environment

  • version of sceptre (sceptre --version)
  • version of python (python --version)
  • which OS/distro

Steps to reproduce

Tell us how to reproduce this issue. Please provide sceptre projct files if possible,
you can use https://plnkr.co/edit/ANFHm61Ilt4mQVgF as a base.

Expected behaviour

Update stack should handle DisableRollback if passed.

Actual behaviour

Nothing.

@alex-harvey-z3q alex-harvey-z3q self-assigned this Aug 3, 2024
alex-harvey-z3q added a commit to alex-harvey-z3q/sceptre that referenced this issue Aug 3, 2024
This adds missing code to complete the implementation of the
DisableRollback feature.

The implementation in 99c839a is clear that it was intended that this
feature would cover both cases of creating and updating stacks, and this
code and unit test was missed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant