Skip to content

Commit

Permalink
Fix integration tests
Browse files Browse the repository at this point in the history
* Integration tests were failing because it was being run
  in the eu-west-1 region.  The CONTRIBUTING.md[1] doc
  clearly states that integration tests are setup to run
  in eu-west-* region.

* Slightly modified the CI workflow to not run integration
  tests until all other tests have executed.

[1] https://github.com/Sceptre/sceptre/blob/master/CONTRIBUTING.md#integration-tests
  • Loading branch information
zaro0508 committed Jan 17, 2024
1 parent cb5c10b commit c8183c0
Showing 1 changed file with 5 additions and 16 deletions.
21 changes: 5 additions & 16 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,11 @@ jobs:
context: .
integration-tests:
needs:
- linting
- packaging
- documentation
- unit-tests
- docker-build
if: ${{ github.ref_type == 'push' }}
runs-on: ubuntu-latest
permissions:
Expand Down Expand Up @@ -111,9 +115,8 @@ jobs:
run: AWS_DEFAULT_REGION=eu-west-1 poetry run behave integration-tests/features --junit --junit-directory build/behave
docker-build-push:
needs:
- docker-build
- integration-tests
if: ${{ github.ref == 'refs/heads/master' }}
if: ${{ (github.ref_type == 'push') && (github.ref == 'refs/heads/master') }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -133,13 +136,6 @@ jobs:
tags: sceptreorg/sceptre:${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
docker-build-release:
needs:
- linting
- packaging
- documentation
- unit-tests
- docker-build
- integration-tests
if: ${{ github.ref_type == 'tag' }}
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -167,13 +163,6 @@ jobs:
tags: sceptreorg/sceptre:${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
pypi-release:
needs:
- linting
- packaging
- documentation
- unit-tests
- docker-build
- integration-tests
if: ${{ github.ref_type == 'tag' }}
runs-on: ubuntu-latest
steps:
Expand Down

0 comments on commit c8183c0

Please sign in to comment.