Adds new operation 'arc' to draw arcs on current path. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ringlej
reviewed
Aug 12, 2023
c_src/scenic/ops/script_ops.h
Outdated
Comment on lines
127
to
128
| FLAG_CCW = 0X01, | ||
| FLAG_CW = 0X02, |
There was a problem hiding this comment.
Suggested change
| FLAG_CCW = 0X01, | |
| FLAG_CW = 0X02, | |
| SWEEP_DIR_CCW = 0X01, | |
| SWEEP_DIR_CW = 0X02, |
ringlej
reviewed
Aug 12, 2023
c_src/scenic/ops/script_ops.h
Outdated
| @@ -148,6 +154,7 @@ SCRIPT_FUNC(line_to, coordinates_t a); | |||
| SCRIPT_FUNC(arc_to, coordinates_t a, coordinates_t b, float radius); | |||
| SCRIPT_FUNC(bezier_to, coordinates_t c0, coordinates_t c1, coordinates_t a); | |||
| SCRIPT_FUNC(quadratic_to, coordinates_t c, coordinates_t a); | |||
| SCRIPT_FUNC(arc, coordinates_t c, float radius, float a0, float a1, int sweep_dir); | |||
There was a problem hiding this comment.
Suggested change
| SCRIPT_FUNC(arc, coordinates_t c, float radius, float a0, float a1, int sweep_dir); | |
| SCRIPT_FUNC(arc, coordinates_t c, float radius, float a0, float a1, sweep_dir_t sweep_dir); |
crertel
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new operation
arcto add arcs to current path.Motivation
Today we only have 2 interfaces to have arcs:
draw_arc/4: which draws an arc on a new path;arc_to/6: which adds an arc on the current path.The need for a third arc operation is that none of the above functions provide a flexible interface for arcs as the
nvgArcdoes.So this new operation
archave the same parameters asnvgArc, which gives a more flexible interface for drawing arcs.Further notes
This PR is a dependency to ScenicFramework/scenic#326, thus it should be merged first.