glfw - Fix hidden cursor on re-focus and window repaint #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work! Let's see if we can get somebody to verify the touch-screen behavior, but this is super neat! |
crertel
approved these changes
Aug 24, 2023
|
@mneumann would you mind updating against current head of |
mneumann
force-pushed
the
fix-mouse-focus-and-window-repaint
branch
from
cda3ccb
to
6a734e4
Compare
|
@crertel no worries. there we go: rebased to recent main :) |
|
@crertel ping :). |
|
Sorry, sorry, @mneumann last rebase and we'll get it merged! (doing end-of-year cleanup) |
* Related bug report: ScenicFramework/scenic#324 * On some Window managers (e.g. CTWM) the window is not repainted when another window is moved over it. Add `refresh_window_callback` and "redraw" (reuse `reshape_window` for now...). * At least on Hikari (Wayland), when the cursor leaves the window and re-enters the window, the cusor was no longer visible. This commit fixes this issue by adding a `focus_window_callback` and explicitly setting the cursor when focus is regained. * NOTE: This might (or might not) show a cursor where no cursor is wanted (touch-screen devices?). To fix this, the `glfwSetCusor` and `glfwSetInputMode` calls in `focus_window_callback` should be conditionalized by a global per-device setting, whether a cursor is desired or not.
mneumann
force-pushed
the
fix-mouse-focus-and-window-repaint
branch
from
6a734e4
to
a948bdd
Compare
|
@crertel no worries! there we go - rebase done :) |
crertel
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related bug report: Mouse cursor hides behind window scenic#324
On some Window managers (e.g. CTWM) the window is not repainted when another window is moved over it. Add
refresh_window_callbackand "redraw" (reusereshape_windowfor now...).At least on Hikari (Wayland), when the cursor leaves the window and re-enters the window, the cusor was no longer visible. This commit fixes this issue by adding a
focus_window_callbackand explicitly setting the cursor when focus is regained.NOTE: This might (or might not) show a cursor where no cursor is wanted (touch-screen devices?). To fix this, the
glfwSetCusorandglfwSetInputModecalls infocus_window_callbackshould be conditionalized by a global per-device setting, whether a cursor is desired or not.