add alpha channel to sprites #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seb3s , sorry for the delay--would you mind rebasing this, if you still want to go forward? We moved around a bunch of things in the pursuit of Cairo backend. |
seb3s
force-pushed
the
add-alpha-channel-to-sprites
branch
from
1d0fe4b
to
0dec0b9
Compare
seb3s
force-pushed
the
add-alpha-channel-to-sprites
branch
from
0dec0b9
to
621c4a6
Compare
|
I did some changes, hope this helps (not sure about the cairo modifications) |
seb3s
force-pushed
the
add-alpha-channel-to-sprites
branch
from
2e48d49
to
95ed575
Compare
|
Hello, |
crertel
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional alpha channel to sprite commands. There is a corresponding PR in scenic to handle that change.