Fix pytorch_wrap regex to catch both nn.X and torch.nn.X#140
Open
nataliakokoromyti wants to merge 1 commit intomainfrom
Open
Fix pytorch_wrap regex to catch both nn.X and torch.nn.X#140nataliakokoromyti wants to merge 1 commit intomainfrom
nataliakokoromyti wants to merge 1 commit intomainfrom
Conversation
The previous pattern `torch\.nn\.(?!...)` only matched fully qualified `torch.nn.Linear` style calls. Generated kernels commonly use `from torch import nn` and then `nn.Conv2d`, `nn.Linear`, etc., which slipped through the check. Changed the pattern to `(?<!\w)nn\.(?!...)` which matches both import styles while avoiding false positives on identifiers like `cnn.layer` via the negative lookbehind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous pattern
torch\.nn\.(?!...)only caught stuff liketorch.nn.Linearbut didn't catch kernels withfrom torch import nnand thennn.Conv2d,nn.Linear, etc. I changed the pattern to(?<!\w)nn\.(?!...)which matches both import styles while avoiding false positives on identifiers likecnn.layervia the negative lookbehind.