Skip to content

Scala 3 support #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jul 6, 2021
Merged

Scala 3 support #202

merged 15 commits into from
Jul 6, 2021

Conversation

@oyvindberg
Copy link
Collaborator

@oyvindberg oyvindberg commented Sep 27, 2020 •
edited
Loading

I'll use this PR to track all the changes necessary to adapt to Scala 3.

@oyvindberg oyvindberg marked this pull request as draft September 27, 2020 12:27
@oyvindberg
Copy link
Collaborator Author

oyvindberg commented Sep 27, 2020 •
edited
Loading

Fixed in Scala 3:

Wontfix in Scala 3, worked around in ST

Remaining issues:

New erasure calculation for new union and intersection types

This ended up being challenging because most usage of ST translates types to scalajs-dom and slinky or scalajs-react types, and I'm not able to implement proper erasure without knowing the entire inheritance chain for all those types.
Working towards this in #310

unreducible application of higher-kinded type with type aliases

This is potentially quite limiting, but at least now there is a workaround - inline type aliases with more than one type parameter :/

Wire up sbt plugin correctly

this PR only makes the CI and CLI tool work with Scala 3. Hopefully easy, but haven't tried yet

@oyvindberg oyvindberg changed the base branch from master to sbt14 September 27, 2020 12:30
@oyvindberg
Copy link
Collaborator Author

ScalablyTyped/Runtime#2

@oyvindberg oyvindberg force-pushed the dotty-support branch 2 times, most recently from d08a844 to 7ad39d3 Compare October 4, 2020 12:48
@oyvindberg oyvindberg force-pushed the sbt14 branch 2 times, most recently from baa52e2 to ddc7a77 Compare October 4, 2020 23:02
Base automatically changed from sbt14 to master October 4, 2020 23:06
@oyvindberg oyvindberg force-pushed the dotty-support branch 3 times, most recently from ce983b2 to 030b21f Compare November 22, 2020 23:08
@oyvindberg oyvindberg force-pushed the dotty-support branch 4 times, most recently from f646734 to 479ca47 Compare December 15, 2020 02:50
@oyvindberg oyvindberg force-pushed the dotty-support branch 3 times, most recently from 92383bf to 4ced3a7 Compare February 18, 2021 23:26
@oyvindberg oyvindberg changed the title Dotty support Scala 3 support May 16, 2021
@oyvindberg oyvindberg force-pushed the dotty-support branch 4 times, most recently from 87a07f8 to d5a0c45 Compare May 24, 2021 23:37
@oyvindberg oyvindberg mentioned this pull request May 26, 2021
Closed
@oyvindberg oyvindberg mentioned this pull request Jun 21, 2021
Closed
This was referenced Jun 29, 2021
Merged
Merged
oyvindberg added 12 commits July 6, 2021 01:10
@oyvindberg
react: type parameters for make
ca6d825
@oyvindberg
Don't generate wildcard types.
1397ecd 
It seems close to impossible to keep generating wildcard types for scala 3. It's also a source of complexity and bugs, so let's remove it altogether :/
@oyvindberg
debugPrinter
16756d5
@oyvindberg
Port to Scala 3
3bc4602 
- Bumps: sbt 1.5.2, bloop 1.4.8, scala.js 1.5.1, runtime 2.4.2
- migrate build.sbt to new syntax
- new scala keywords
- union and intersection types
- implement erasure for scala 3
- disable optional braces
- emit top-level members instead of package object (still in package.scala)
@oyvindberg
build snapshots
fb3c902
@oyvindberg
workaround for scala/scala3#12588
68ba6d9
@oyvindberg
fork tests
c2a3215
@oyvindberg
better erasure for this.type
17f202e
@oyvindberg
val a: Null = js.native seems to be forbidden now
07c4acf
@oyvindberg
react: don't generate js.Any refs
5956e7e
@oyvindberg
Workaround scala/scala3#12722
f1f1c98
@oyvindberg
Reinstate primitive hack for erasure of intersection types also for s…
e726fbf 
…cala 3
@oyvindberg oyvindberg marked this pull request as ready for review July 5, 2021 23:18
@oyvindberg oyvindberg merged commit 627d7fc into master Jul 6, 2021
@oyvindberg oyvindberg deleted the dotty-support branch July 6, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oyvindberg