Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node-forge and google-p12-pem in /octokit #10

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Mar 30, 2023

Bumps node-forge and google-p12-pem. These dependencies needed to be updated together.
Updates node-forge from 0.10.0 to 1.3.1

Changelog

Sourced from node-forge's changelog.

1.3.1 - 2022-03-29

Fixes

  • RFC 3447 and RFC 8017 allow for optional DigestAlgorithm NULL parameters for sha* algorithms and require NULL paramters for md2 and md5 algorithms.

1.3.0 - 2022-03-17

Security

  • Three RSA PKCS#1 v1.5 signature verification issues were reported by Moosa Yahyazadeh (moosa-yahyazadeh@uiowa.edu).
  • HIGH: Leniency in checking digestAlgorithm structure can lead to signature forgery.
  • HIGH: Failing to check tailing garbage bytes can lead to signature forgery.
  • MEDIUM: Leniency in checking type octet.
    • DigestInfo is not properly checked for proper ASN.1 structure. This can lead to successful verification with signatures that contain invalid structures but a valid digest.
    • CVE ID: CVE-2022-24773
    • GHSA ID: GHSA-2r2c-g63r-vccr

Fixed

  • [asn1] Add fallback to pretty print invalid UTF8 data.
  • [asn1] fromDer is now more strict and will default to ensuring all input bytes are parsed or throw an error. A new option parseAllBytes can disable this behavior.
    • NOTE: The previous behavior is being changed since it can lead to security issues with crafted inputs. It is possible that code doing custom DER parsing may need to adapt to this new behavior and optional flag.
  • [rsa] Add and use a validator to check for proper structure of parsed ASN.1

... (truncated)

Commits

Updates google-p12-pem from 3.0.3 to 3.1.4

Release notes

Sourced from google-p12-pem's releases.

v3.1.4

3.1.4 (2022-04-11)

Bug Fixes

v3.1.3

3.1.3 (2022-01-10)

Bug Fixes

  • deps: update dependency node-forge to v1 (#382) (078735b)

google-p12-pem v3.1.2

Bug Fixes

google-p12-pem v3.1.1

Bug Fixes

v3.1.0

Features

  • add gcf-owl-bot[bot] to ignoreAuthors (#318) (e93e51b)
Changelog

Sourced from google-p12-pem's changelog.

3.1.4 (2022-04-11)

Bug Fixes

3.1.3 (2022-01-10)

Bug Fixes

  • deps: update dependency node-forge to v1 (#382) (078735b)

3.1.2 (2021-08-11)

Bug Fixes

3.1.1 (2021-07-21)

Bug Fixes

3.1.0 (2021-06-10)

Features

  • add gcf-owl-bot[bot] to ignoreAuthors (#318) (e93e51b)
Commits
  • aff0086 chore(main): release 3.1.4 (#404)
  • f375cca fix(deps): force fixed version of node-forge (#403)
  • e602210 chore(deps): update actions/checkout action to v3 (#1392) (#401)
  • f7df70d chore(deps): update actions/setup-node action to v3 (#1393) (#400)
  • 4095df8 chore: Enable Size-Label bot in all googleapis NodeJs repositories (#1382) (#...
  • 850355c chore(deps): update actions/checkout action to v3 (#395)
  • 40b7cd7 chore(deps): update actions/setup-node action to v3 (#394)
  • 65b5c88 docs(nodejs): version support policy edits (#1346) (#393)
  • ce2ed68 chore(deps): update actions/setup-node action to v2 (#391)
  • 7ddc2d0 build(node): switch back to keystore for publication (#1328) (#390)
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [node-forge](https://github.com/digitalbazaar/forge) and [google-p12-pem](https://github.com/googleapis/google-p12-pem). These dependencies needed to be updated together.

Updates `node-forge` from 0.10.0 to 1.3.1
- [Release notes](https://github.com/digitalbazaar/forge/releases)
- [Changelog](https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md)
- [Commits](digitalbazaar/forge@0.10.0...v1.3.1)

Updates `google-p12-pem` from 3.0.3 to 3.1.4
- [Release notes](https://github.com/googleapis/google-p12-pem/releases)
- [Changelog](https://github.com/googleapis/google-p12-pem/blob/main/CHANGELOG.md)
- [Commits](googleapis/google-p12-pem@v3.0.3...v3.1.4)

---
updated-dependencies:
- dependency-name: node-forge
  dependency-type: indirect
- dependency-name: google-p12-pem
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 30, 2023
@Say383 Say383 merged commit 01cdb01 into master Mar 30, 2023
@Say383 Say383 deleted the dependabot/npm_and_yarn/octokit/node-forge-and-google-p12-pem-1.3.1 branch March 30, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant