-
Notifications
You must be signed in to change notification settings - Fork 0
fix: 원본 이미지에서 썸네일 이미지 제공으로 수정 #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Walkthrough원본 이미지 URL을 썸네일 URL로 교체하고, 관련 API 문서와 Swagger 스키마 설명을 업데이트한 변경사항입니다. 서비스 로직, 데이터 타입, 공개 인터페이스의 구조적 변화는 없습니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/main/java/com/cheeeese/cheese4cut/dto/response/Cheese4cutPreviewResponse.java (1)
49-49: 예시 URL이 변경 사항과 일치하지 않습니다.description은 "사진 썸네일 URL"로 올바르게 수정되었지만, example URL에 여전히
/original/경로가 포함되어 있습니다. 썸네일을 제공하는 것으로 변경되었다면, 예시 URL도 실제 썸네일 경로를 반영하도록 업데이트하는 것이 좋습니다.src/main/java/com/cheeeese/cheese4cut/dto/response/Cheese4cutFinalResponse.java (1)
36-36: 예시 URL이 변경 사항과 일치하지 않습니다.description은 "사진 썸네일 URL"로 올바르게 업데이트되었지만, example URL에
/original/경로가 포함되어 있어 실제 썸네일 URL 형식과 다를 수 있습니다. 예시를 실제 썸네일 경로로 수정하는 것을 권장합니다.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/main/java/com/cheeeese/cheese4cut/application/Cheese4cutService.java(2 hunks)src/main/java/com/cheeeese/cheese4cut/dto/response/Cheese4cutFinalResponse.java(1 hunks)src/main/java/com/cheeeese/cheese4cut/dto/response/Cheese4cutPreviewResponse.java(1 hunks)src/main/java/com/cheeeese/cheese4cut/presentation/swagger/Cheese4cutSwagger.java(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-10-31T13:17:52.523Z
Learnt from: dahyun24
Repo: Say-Cheeeese/BE PR: 35
File: src/main/java/com/cheeeese/photo/application/PhotoService.java:46-52
Timestamp: 2025-10-31T13:17:52.523Z
Learning: In src/main/java/com/cheeeese/photo/application/PhotoService.java, the getRecentThumbnailUrls method intentionally returns only the first thumbnail URL when photos.size() < 5, rather than returning all available thumbnails. This is according to product requirements: 0 photos → empty list, 1-4 photos → single thumbnail (most recent), 5 photos → all 5 thumbnails.
Applied to files:
src/main/java/com/cheeeese/cheese4cut/dto/response/Cheese4cutPreviewResponse.javasrc/main/java/com/cheeeese/cheese4cut/application/Cheese4cutService.javasrc/main/java/com/cheeeese/cheese4cut/dto/response/Cheese4cutFinalResponse.java
📚 Learning: 2025-11-13T12:56:22.161Z
Learnt from: dahyun24
Repo: Say-Cheeeese/BE PR: 58
File: src/main/java/com/cheeeese/cheese4cut/application/Cheese4cutService.java:149-156
Timestamp: 2025-11-13T12:56:22.161Z
Learning: In src/main/java/com/cheeeese/cheese4cut/application/Cheese4cutService.java, the finalizeCheese4cut method intentionally re-sorts photos using findAllByIdInOrderByLikesDescCreatedDesc(request.photoIds()) instead of preserving the client's requested order. This is a defensive measure to ensure photos are always ordered by likes (DESC) and creation time (DESC), regardless of what order the client sends, preventing incorrect ordering from client errors.
Applied to files:
src/main/java/com/cheeeese/cheese4cut/dto/response/Cheese4cutPreviewResponse.javasrc/main/java/com/cheeeese/cheese4cut/presentation/swagger/Cheese4cutSwagger.javasrc/main/java/com/cheeeese/cheese4cut/application/Cheese4cutService.javasrc/main/java/com/cheeeese/cheese4cut/dto/response/Cheese4cutFinalResponse.java
🔇 Additional comments (3)
src/main/java/com/cheeeese/cheese4cut/dto/response/Cheese4cutFinalResponse.java (1)
33-33: LGTM!"원본" 용어를 제거하여 더 일반적인 설명으로 변경한 것이 적절합니다.
src/main/java/com/cheeeese/cheese4cut/presentation/swagger/Cheese4cutSwagger.java (1)
34-35: LGTM!API 설명이 썸네일 URL 제공으로 명확하게 업데이트되었습니다.
src/main/java/com/cheeeese/cheese4cut/application/Cheese4cutService.java (1)
69-69: 리뷰 코멘트는 부정확합니다. 다른 엔티티 타입에 적절한 메서드 명명입니다.검증 결과, 두 라인에서 호출하는 메서드는 다른 엔티티 타입에 속한 것으로 확인되었습니다:
- Line 69:
Cheese4cutPhoto엔티티의thumbnailImageUrl필드에 대한getThumbnailImageUrl()호출- Line 113:
Photo엔티티의thumbnailUrl필드에 대한getThumbnailUrl()호출각 엔티티가 서로 다른 필드명을 가지고 있으므로 getter 메서드명이 다른 것은 올바른 설계입니다.
Likely an incorrect or invalid review comment.
🔗 연관된 이슈
🚀 변경 유형
📝 작업 내용
📸 스크린샷
💬 리뷰 요구사항
📜 리뷰 규칙
Reviewer는 아래 P5 Rule을 참고하여 리뷰를 진행합니다.
P5 Rule을 통해 Reviewer는 Reviewee에게 리뷰의 의도를 보다 정확히 전달할 수 있습니다.
Summary by CodeRabbit
릴리스 노트
버그 수정
문서
✏️ Tip: You can customize this high-level summary in your review settings.