feat: Photo, UserAlbum 엔티티에 Join 추가 및 NewEnterResponse 수정 #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walkthrough도메인 엔티티의 원시 외래키(userId, albumId)를 JPA 관계(User, Album)로 리팩토링하고, 최근 사진 응답을 업로더 정보가 포함된 DTO(List)로 변경하며 매퍼·리포지토리·서비스 호출을 이에 맞춰 조정했습니다. Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant AlbumService
participant PhotoService
participant PhotoRepository
participant AlbumMapper
participant UserAlbumMapper
User->>AlbumService: enterAlbum(token, currentUser)
AlbumService->>PhotoService: getRecentPhotosForNewEnter(albumId)
PhotoService->>PhotoRepository: findRecentPhotosByAlbumIdAndStatus(albumId, ACTIVE, PageRequest)
PhotoRepository-->>PhotoService: List<Photo>
PhotoService-->>AlbumService: List<Photo>
AlbumService->>AlbumMapper: toRecentPhotoResponse(Photo) *map*
AlbumMapper-->>AlbumService: List<RecentPhotoResponse>
AlbumService->>UserAlbumMapper: toEntity(currentUser, album, Role.GUEST/MAKER)
UserAlbumMapper-->>AlbumService: UserAlbum
AlbumService-->>User: NewEnterResponse(recentPhotos: List<RecentPhotoResponse>, ...)
sequenceDiagram
participant Before as 이전 흐름
participant After as 변경된 흐름
Before->>Before: Photo(userId: Long, albumId: Long)
After->>After: Photo(user: User, album: Album)
Before->>Before: PhotoMapper.toEntity(Long userId, Long albumId)
After->>After: PhotoMapper.toEntity(User user, Album album)
Before->>Before: recentPhotoUrls: List<String>
After->>After: recentPhotos: List<RecentPhotoResponse>
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes
Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-10-31T13:17:52.512ZApplied to files:
🧬 Code graph analysis (1)src/main/java/com/cheeeese/album/application/AlbumService.java (2)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
src/main/java/com/cheeeese/album/application/AlbumService.java(5 hunks)src/main/java/com/cheeeese/album/domain/UserAlbum.java(3 hunks)src/main/java/com/cheeeese/album/dto/response/NewEnterResponse.java(2 hunks)src/main/java/com/cheeeese/album/infrastructure/mapper/AlbumMapper.java(3 hunks)src/main/java/com/cheeeese/album/infrastructure/mapper/UserAlbumMapper.java(1 hunks)src/main/java/com/cheeeese/album/infrastructure/persistence/UserAlbumRepository.java(1 hunks)src/main/java/com/cheeeese/photo/application/PhotoService.java(3 hunks)src/main/java/com/cheeeese/photo/application/validator/PhotoValidator.java(2 hunks)src/main/java/com/cheeeese/photo/domain/Photo.java(3 hunks)src/main/java/com/cheeeese/photo/infrastructure/mapper/PhotoMapper.java(1 hunks)src/main/java/com/cheeeese/photo/infrastructure/persistence/PhotoRepository.java(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-31T13:17:52.512Z
Learnt from: dahyun24
Repo: Say-Cheeeese/BE PR: 35
File: src/main/java/com/cheeeese/photo/application/PhotoService.java:46-52
Timestamp: 2025-10-31T13:17:52.512Z
Learning: In src/main/java/com/cheeeese/photo/application/PhotoService.java, the getRecentThumbnailUrls method intentionally returns only the first thumbnail URL when photos.size() < 5, rather than returning all available thumbnails. This is according to product requirements: 0 photos → empty list, 1-4 photos → single thumbnail (most recent), 5 photos → all 5 thumbnails.
Applied to files:
src/main/java/com/cheeeese/album/dto/response/NewEnterResponse.javasrc/main/java/com/cheeeese/album/application/AlbumService.javasrc/main/java/com/cheeeese/photo/application/PhotoService.javasrc/main/java/com/cheeeese/album/infrastructure/mapper/AlbumMapper.javasrc/main/java/com/cheeeese/photo/infrastructure/persistence/PhotoRepository.java
🧬 Code graph analysis (2)
src/main/java/com/cheeeese/album/application/AlbumService.java (2)
src/main/java/com/cheeeese/album/infrastructure/mapper/AlbumMapper.java (1)
AlbumMapper(13-149)src/main/java/com/cheeeese/album/infrastructure/mapper/UserAlbumMapper.java (1)
UserAlbumMapper(8-18)
src/main/java/com/cheeeese/photo/application/PhotoService.java (1)
src/main/java/com/cheeeese/photo/infrastructure/mapper/PhotoMapper.java (1)
PhotoMapper(12-42)
🔇 Additional comments (5)
src/main/java/com/cheeeese/album/infrastructure/persistence/UserAlbumRepository.java (1)
13-20: JPQL로 엔티티 기반 조회를 명시한 점이 깔끔합니다.src/main/java/com/cheeeese/photo/application/validator/PhotoValidator.java (1)
106-119: 엔티티 참조를 활용한 검증으로 일관성이 확보된 것 확인했습니다.src/main/java/com/cheeeese/photo/infrastructure/mapper/PhotoMapper.java (1)
14-22: User·Album 엔티티를 직접 세팅하도록 바꾼 구성 잘 반영되었습니다.src/main/java/com/cheeeese/album/application/AlbumService.java (1)
161-177: 최근 사진 응답이 기획 요구(1~4장일 때 1장, 5장일 때 5장)를 그대로 유지하고 있어요.Based on learnings
src/main/java/com/cheeeese/album/infrastructure/mapper/UserAlbumMapper.java (1)
10-16: 엔티티 참조 기반 빌더 구성이 일관되게 정리되었습니다.
src/main/java/com/cheeeese/photo/infrastructure/persistence/PhotoRepository.java
Show resolved
Hide resolved
2 tasks
This was referenced Nov 10, 2025
Merged
Merged
This was referenced Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🚀 변경 유형
📝 작업 내용
📸 스크린샷
💬 리뷰 요구사항
Summary by CodeRabbit
새로운 기능
리팩터