-
Notifications
You must be signed in to change notification settings - Fork 0
docs: Expand README with API and architecture details #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added detailed sections for API documentation, ERD, system architecture, technology stack, CI/CD, and monitoring.
WalkthroughREADME.md์์ ๊ธฐ์กด ๋จ์ผ ๋ฆฌํฌ์งํ ๋ฆฌ ์ ๋ชฉ์ ์ ๊ฑฐํ๊ณ ๊ณต์ฉ ์๋น์ค ์ค๋ช , ํ ๊ตฌ์ฑ, Swagger API ๋ช ์ธ ๋งํฌ, ERDยท์์คํ ์ํคํ ์ฒ ์ด๋ฏธ์ง ๋ฐ ๊ธฐ์ ์คํ(์ธ์ด/ํ๋ ์์ํฌ, DB/์บ์, CI/CD/๋ฐฐํฌ, ๋ชจ๋ํฐ๋ง/๋ก๊น )๊ณผ ์ปค๋ฐ ์ปจ๋ฒค์ ์ ํฌํจํ ๋ฌธ์ ์ ๋ฐ์ ๋์ฒดยทํ์ฅํ์ต๋๋ค. (50๋จ์ด ์ด๋ด) Changes
Estimated code review effort๐ฏ 2 (Simple) | โฑ๏ธ ~10 minutes
Poem
Pre-merge checks and finishing touchesโ Passed checks (3 passed)
โจ Finishing touches๐งช Generate unit tests (beta)
๐ Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ๐ Files selected for processing (1)
๐งฐ Additional context used๐ช markdownlint-cli2 (0.18.1)README.md10-10: Images should have alternate text (alt text) (MD045, no-alt-text) 10-10: Images should have alternate text (alt text) (MD045, no-alt-text) 70-70: No space after hash on atx style heading (MD018, no-missing-space-atx) ๐ Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
๐งน Nitpick comments (1)
README.md (1)
6-10: GitHub ์์ฐ ์ด๋ฏธ์ง URL์ ์ฅ๊ธฐ ์์ ์ฑ ํ์ธERD์ ์์คํ ์ํคํ ์ฒ ์ด๋ฏธ์ง๊ฐ GitHub asset URL๋ก ํธ์คํ ๋๊ณ ์์ต๋๋ค. ์ด URL๋ค์ด ์ ์ฅ์์์ ์ ๊ฑฐ๋๊ฑฐ๋ ์ด๋ํ ๊ฒฝ์ฐ ์์๋ ์ ์์ผ๋, ์ด๋ฏธ์ง๋ฅผ ํ๋ก์ ํธ ๋๋ ํ ๋ฆฌ(์:
docs/images/)์ ์ ์ฅํ๊ณ ์๋ ๊ฒฝ๋ก๋ก ์ฐธ์กฐํ๋ ๊ฒ์ ๊ถ์ฅํฉ๋๋ค.
๐ Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
๐ Files selected for processing (1)
README.md(1 hunks)
๐ Additional comments (2)
README.md (2)
3-4: Swagger API ๋ช ์ธ์ ๋งํฌ ์ ๊ทผ์ฑ ํ์ธ ํ์๊ฐ๋ฐ ํ๊ฒฝ์ Swagger ๋งํฌ(
https://dev.say-cheese.me/swagger-ui/index.html#/)๊ฐ ๊ณต๊ฐ์ ์ผ๋ก ์ ๊ทผ ๊ฐ๋ฅํ์ง, ๋๋ ์ธ์ฆ์ด ํ์ํ์ง ํ์ธํ์๊ธฐ ๋ฐ๋๋๋ค. ํ์์ ํ๋ก๋์ ํ๊ฒฝ ๋งํฌ๋ก ์ ๋ฐ์ดํธํ๊ฑฐ๋ ์ ๊ทผ ์ ํ์ ๋ฌธ์ํํ๋ ๊ฒ์ ๊ถ์ฅํฉ๋๋ค.
12-32: ๊ธฐ์ ์คํ ์น์ ๊ตฌ์ฑ - ํ์ํ ๊ตฌ์กฐ์ ์ค๋ช๊ธฐ์ ์คํ์ด ๋ช ํํ ์นดํ ๊ณ ๋ฆฌ๋ณ๋ก ์ ์ ๋ฆฌ๋์ด ์์ผ๋ฉฐ, ๊ฐ ๋๊ตฌ์ ๋ชฉ์ ์ ์ค๋ช ํ๋ ํ๊ธ ์ฃผ์์ด ์ดํด๋๋ฅผ ๋์ ๋๋ค. ํนํ CI/CD ์๋ํ ํ๋ฆ๊ณผ ๋ชจ๋ํฐ๋ง ์คํ์ ์ธ๋ถ ์ค๋ช ์ด ์๋ก์ด ํ์์ด๋ ๊ธฐ์ฌ์์๊ฒ ์ ์ฉํ ๊ฒ ๊ฐ์ต๋๋ค.
๋ค๋ง ๋ค์ ํญ๋ชฉ๋ค์ ์ ํ์ฑ์ ํ์ธํ์๊ธฐ ๋ฐ๋๋๋ค:
- Blue-Green ๋ฐฐํฌ๊ฐ ์ค์ ์ด์ ํ๊ฒฝ์ ๊ตฌํ๋์ด ์๋์ง ํ์ธ
- ๋ชจ๋ํฐ๋ง ์คํ(Promtail, Loki, Grafana, Prometheus)์ด ๋ชจ๋ ํ์ฌ ํ์ฑ ์ด์ ์ค์ธ์ง ํ์ธ
- ๋ฒ์ ์ ๋ณด(Spring Boot 3.5.6, Java 21)๊ฐ ํ์ฌ ํ๋ก์ ํธ์์ ์ฌ์ฉ ์ค์ธ ์ ํํ ๋ฒ์ ์ธ์ง ํ์ธ
zyovn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 5
๐ Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
โ Files ignored due to path filters (1)
img.pngis excluded by!**/*.png
๐ Files selected for processing (1)
README.md(1 hunks)
๐งฐ Additional context used
๐ช markdownlint-cli2 (0.18.1)
README.md
2-2: Bare URL used
(MD034, no-bare-urls)
7-7: Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
9-9: Images should have alternate text (alt text)
(MD045, no-alt-text)
9-9: Images should have alternate text (alt text)
(MD045, no-alt-text)
69-69: No space after hash on atx style heading
(MD018, no-missing-space-atx)
๐ Additional comments (1)
README.md (1)
12-42: ๋ฌธ์ํ ํ์ฅ์ด ์ฐ์ํฉ๋๋ค.API ๋ช ์ธ์, ERD, ์์คํ ์ํคํ ์ฒ, ๊ธฐ์ ์คํ, CI/CD, ๋ชจ๋ํฐ๋ง/๋ก๊น ์น์ ์ด ์ ์ ๋ฆฌ๋์ด ์์ต๋๋ค. ํ์๋ค์ด ํ๋ก์ ํธ ์ ์ฒด ๊ตฌ์กฐ์ ์ด์ ๋ฐฉ์์ ๋ช ํํ ์ดํดํ ์ ์๋๋ก ๊ตฌ์ฑ๋์์ต๋๋ค. Blue-Green ๋ฐฐํฌ, ์ค์ ์ง์คํ ๋ก๊น , ๋ชจ๋ํฐ๋ง ์ ๋ต์ด ๊ตฌ์ฒด์ ์ผ๋ก ์ค๋ช ๋์ด ์์ด ์ข์ต๋๋ค.

Added detailed sections for API documentation, ERD, system architecture, technology stack, CI/CD, and monitoring.
๐ ๋ณ๊ฒฝ ์ ํ
๐ ์์ ๋ด์ฉ
๐ฌ ๋ฆฌ๋ทฐ ์๊ตฌ์ฌํญ
๐ ๋ฆฌ๋ทฐ ๊ท์น
Reviewer๋ ์๋ P5 Rule์ ์ฐธ๊ณ ํ์ฌ ๋ฆฌ๋ทฐ๋ฅผ ์งํํฉ๋๋ค.
P5 Rule์ ํตํด Reviewer๋ Reviewee์๊ฒ ๋ฆฌ๋ทฐ์ ์๋๋ฅผ ๋ณด๋ค ์ ํํ ์ ๋ฌํ ์ ์์ต๋๋ค.
Summary by CodeRabbit
โ๏ธ Tip: You can customize this high-level summary in your review settings.