Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The contour_label_fontsize parameter in _pdp_contour_plot() causes TypeError #40

Closed
angertdevsingh opened this issue Oct 22, 2018 · 19 comments
Labels

Comments

@angertdevsingh
Copy link
Contributor

On line 251 in pdp_plot_utils.py, one of the parameters for _pdp_contour_plot() is contour_label_fontsize and this causes the following error:

TypeError: clabel() got an unexpected keyword argument 'contour_label_fontsize'

According to the documentation for matplotlib.pyplot.clabel(), the parameter should be called fontsize.

Source: clabel() documentation

angertdevsingh added a commit to angertdevsingh/PDPbox that referenced this issue Oct 22, 2018
Change contour_label_fontsize parameter in _pdp_contour_plot() to fontsize

This fixes Issue SauceCat#40
SauceCat pushed a commit that referenced this issue Dec 8, 2018
Change contour_label_fontsize parameter in _pdp_contour_plot() to fontsize

This fixes Issue #40
@jcusick13
Copy link

Hi @SauceCat, I was wondering if there were plans coming up to push a new release version out to PyPI that included this fix. Thanks!

@Wolemercy
Copy link

This worked.
Merci!

@Photonsinnovate
Copy link

This worked.
Merci!

Hi Wolemercy, Could you please explain exactly how you made it work?

@Photonsinnovate
Copy link

This worked.
Merci!

Hi Wolemercy, Could you please explain exactly how you made it work?

Hi Wole, I have resolved this. Thank you

@Wolemercy
Copy link

Cheers mate

@johann-DP
Copy link

Hi,
Sorry Wolemercy but I don't… Could you explain ti me, please ?

@Wolemercy
Copy link

Aye aye
You need to locate this python file "pdp_plot_utils.py" on your PC. It's part of the PDPBox package you installed. Open the file and replace the code in line 251 with this:

inter_ax.clabel(c2, fontsize=fontsize, inline=1)

Save and close the file. You should be good to go.

@johann-DP
Copy link

Hi,
merci pour le retour mais ça marche pô : toujours le même pb…
Je pense qu'il faut downgrader un package mais je ne vois pas lequel.

@johann-DP
Copy link

Oups,
it works! (I forgoted to restart… once again).
Thanks a lot!

@JRBOH
Copy link

JRBOH commented Nov 13, 2020

This helped me, especially @Wolemercy's comment! Thanks, guys.

@Wolemercy
Copy link

Wolemercy commented Nov 13, 2020 via email

@Wolemercy
Copy link

Wolemercy commented Nov 13, 2020 via email

@Batev
Copy link

Batev commented Nov 13, 2020

Hi @SauceCat, I was wondering if there were plans coming up to push a new release version out to PyPI that included this fix. Thanks!

Still waiting for the PyPI update ...

@veeralakrishna
Copy link

Why it's not updated in the PyPI yet??

@SauceCat
Copy link
Owner

SauceCat commented Mar 9, 2021 via email

@Batev
Copy link

Batev commented Mar 9, 2021

Both installing from the repo and editing the file as @Wolemercy suggested work fine. However, it is really inconvenient to have to manually install PDPBox because of this bug instead of using pip and a requirements file. Since the repo is no longer supported I/we would be happy to at least have the latest version in PyPI.

@SauceCat
Copy link
Owner

SauceCat commented Mar 9, 2021 via email

@SauceCat SauceCat added the to-do label Mar 13, 2021
@SauceCat
Copy link
Owner

@Batev @veeralakrishna Please check the new release.

@veeralakrishna
Copy link

Thank you for the New Release @SauceCat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants