Fix make uuid-fix to catch multiple whitespaces. #7365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR when running `make uuid-fix` to generate ids the script was not catching lines with `:id: ` having whitespaces after the `:id:` token. With this fix (by adding `\s*` to match any quantity of whitespace it is now fixed.
Codecov Report
@@ Coverage Diff @@
## master #7365 +/- ##
==========================================
+ Coverage 68.33% 68.35% +0.02%
==========================================
Files 29 29
Lines 3647 3647
==========================================
+ Hits 2492 2493 +1
+ Misses 1155 1154 -1
Continue to review full report at Codecov.
|
vijay8451
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR when running
make uuid-fixto generate idsthe script was not catching lines with
:id:having whitespacesafter the
:id:token.With this fix (by adding
\s*to match any quantity of whitespace it is now fixed.