Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uuid-fix script and also replacing existing duplicates #5337

Merged
merged 1 commit into from
Oct 3, 2017
Merged

Fix uuid-fix script and also replacing existing duplicates #5337

merged 1 commit into from
Oct 3, 2017

Conversation

rochacbruno
Copy link
Contributor

@rochacbruno rochacbruno commented Oct 3, 2017 •
edited by elyezer
Loading

already checked with @elyezer and Polarion will be good with this
change by creating a new test for the duplicated IDs.

@rochacbruno
Fix uuid-fix script and also replacing existing duplicates
18f2236 
already checked with @elyezer and Polarion will be god with this
change by creating a new test for the duplicated IDs.
@codecov
Copy link

codecov bot commented Oct 3, 2017 •
edited
Loading

Codecov Report

Merging #5337 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #5337     +/-   ##
========================================
+ Coverage    60.8%   60.9%   +0.1%     
========================================
  Files          34      34             
  Lines        3671    3671             
========================================
+ Hits         2232    2236      +4     
+ Misses       1439    1435      -4
Impacted Files Coverage Δ
robottelo/decorators/func_locker.py 94.73% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d1114a...18f2236. Read the comment docs.

@rochacbruno rochacbruno requested review from sghai and renzon October 3, 2017 15:46
@rochacbruno rochacbruno mentioned this pull request Oct 3, 2017
Merged
@rochacbruno rochacbruno requested a review from abalakh October 3, 2017 16:32
@rochacbruno
Copy link
Contributor Author

This PR is blocking all other PRs to pass in Travis CI

@rochacbruno rochacbruno added enhancement An addition to the robottelo framework High Priority Get this done or merged soon labels Oct 3, 2017
elyezer
elyezer approved these changes Oct 3, 2017
View reviewed changes
Copy link
Contributor

@elyezer elyezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it.

abalakh
abalakh approved these changes Oct 3, 2017
View reviewed changes
Copy link
Contributor

@abalakh abalakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@abalakh abalakh merged commit 73a16ae into SatelliteQE:master Oct 3, 2017
rochacbruno added a commit to rochacbruno/robottelo that referenced this pull request Nov 7, 2017
@rochacbruno
Fix uuid-fix script and also replacing existing duplicates (Satellite…
868d315 
…QE#5337)

already checked with @elyezer and Polarion will be god with this
change by creating a new test for the duplicated IDs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elyezer elyezer elyezer approved these changes

@abalakh abalakh abalakh approved these changes

@sghai sghai Awaiting requested review from sghai

@renzon renzon Awaiting requested review from renzon

Assignees
No one assigned
Labels
enhancement An addition to the robottelo framework High Priority Get this done or merged soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rochacbruno @elyezer @abalakh