Initial work to increase coverage on robottelo.cli module #4707
Conversation
using pytest parametrize and pytest-mock added some tests to assert the call of cli methods more tests will be added later
|
@rochacbruno, thanks for your PR! By analyzing the history of the files in this pull request, we identified @renzon, @rplevka and @sghai to be potential reviewers. |
| @@ -566,7 +566,7 @@ def configure_puppet_test(): | |||
| puppet_env.location.append(loc) | |||
| puppet_env.organization.append(org) | |||
| puppet_env = puppet_env.update(['location', 'organization']) | |||
| Proxy.importclasses({ | |||
| Proxy.import_classes({ | |||
There was a problem hiding this comment.
renamed this method to keep the standard with all other method names. (grepped and renamed all references)
| @@ -33,7 +33,7 @@ def _csv_reader(output): | |||
| data = data.encode('utf8') | |||
| handler = StringIO(data) | |||
|
|
|||
| for row in csv.reader(handler): | |||
| for row in csv.reader(handler): # pragma: no cover | |||
There was a problem hiding this comment.
Added no cover here because it is difficult to merge coverage reports for python 2 and 3 in final report
| @@ -367,6 +367,8 @@ def test_parse_info(self): | |||
| ' Repo ID: 10', | |||
| ' 2) Repo Name: repo2', | |||
| ' Repo ID: 20', | |||
| ' 3) Repo Name => repo3', | |||
| ' Repo ID => 30', | |||
There was a problem hiding this comment.
included => to test this alternative format and hit the parser.
Codecov Report
@@ Coverage Diff @@
## master #4707 +/- ##
==========================================
+ Coverage 40.48% 41.47% +0.98%
==========================================
Files 89 89
Lines 7121 7113 -8
==========================================
+ Hits 2883 2950 +67
+ Misses 4238 4163 -75
Continue to review full report at Codecov.
|
using pytest parametrize and pytest-mock
added some tests to assert the call of cli methods
more tests will be added later
NOTE: Using pytest style for robottelo tests, while for
tests/forremanwe keep usingunittestfor compatibility with Junit reports andsubTest. Fortests/robottelowe can usepytestor even mix it withunittest.