pass --flavor satellite when deploying using foremanctl by evgeni · Pull Request #22356 · SatelliteQE/robottelo

evgeni · 2026-08-05T13:16:06Z

Problem Statement

Solution

Related Issues

Summary by Sourcery

New Features:

Add support for specifying the Satellite flavor in foremanctl-based installations.

sourcery-ai · 2026-08-05T13:16:13Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensure Satellite installation via foremanctl always passes the --flavor satellite option so deployments use the correct flavor by default.

Sequence diagram for Satellite installation via foremanctl with flavor option

sequenceDiagram
    actor Tester
    participant robottelo_hosts as install_satellite_foremanctl
    participant foremanctl

    Tester->>robottelo_hosts: install_satellite_foremanctl
    robottelo_hosts->>robottelo_hosts: build default_parameters
    robottelo_hosts->>robottelo_hosts: add --flavor satellite
    robottelo_hosts->>foremanctl: execute foremanctl with default_parameters
    foremanctl-->>Tester: return installation result

File-Level Changes

Change	Details	Files
Include the Satellite flavor flag in default foremanctl install parameters so deployments consistently target the Satellite flavor.	Add `--flavor satellite` to the list of default parameters passed to `foremanctl` in `install_satellite_foremanctl` Keep existing admin username and password parameters unchanged while prepending the flavor flag	`robottelo/hosts.py`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey - I've left some high level feedback:

The new '--flavor satellite' entry bundles flag and value into a single string, which may not match how default_parameters is consumed elsewhere (e.g., as separate args); consider splitting into '--flavor' and 'satellite' to align with typical argument handling.
If different flavors might be needed in the future, consider making the flavor value configurable (e.g., via settings or a function parameter) instead of hardcoding 'satellite' here.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The new `'--flavor satellite'` entry bundles flag and value into a single string, which may not match how `default_parameters` is consumed elsewhere (e.g., as separate args); consider splitting into `'--flavor'` and `'satellite'` to align with typical argument handling.
- If different flavors might be needed in the future, consider making the flavor value configurable (e.g., via `settings` or a function parameter) instead of hardcoding `'satellite'` here.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

evgeni · 2026-08-05T13:23:03Z

The new '--flavor satellite' entry bundles flag and value into a single string, which may not match how default_parameters is consumed elsewhere (e.g., as separate args); consider splitting into '--flavor' and 'satellite' to align with typical argument handling.

Before this PR, the default_parameters were as follows:

        default_parameters = [
            f'--initial-admin-username {settings.server.admin_username}',
            f'--initial-admin-password {settings.server.admin_password}',
        ]

I'll leave it as an exercise to the reader to define "typical".

evgeni · 2026-08-05T13:36:48Z

trigger: test-robottelo
pytest: tests/foreman/foremanctl/test_install_foremanctl.py
deployment_type: container
theforeman:
  foremanctl: 726

Satellite-QE · 2026-08-05T14:41:11Z

PRT Result

Build Number: 16346
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/foremanctl/test_install_foremanctl.py --external-logging
Test Result : ================= 34 warnings, 21 errors in 3353.25s (0:55:53) =================

evgeni · 2026-08-05T14:42:39Z

foremanctl deploy: error: argument --flavor: invalid choice: 'satellite' (choose from katello)

seems its not picking up the packit build, why?

shubhamsg199 · 2026-08-05T15:23:12Z

foremanctl deploy: error: argument --flavor: invalid choice: 'satellite' (choose from katello)
seems its not picking up the packit build, why?

This is because of https://gitlab.cee.redhat.com/satelliteqe/satlab-tower/-/merge_requests/1554 .
upstream-pr-install cannot find the host in the inventory and the workflow passes as ansible doesn't error out.
I was testing this to fix it here and is working.
Can you add the small change from the PR and run the PRT again?

evgeni · 2026-08-05T15:45:22Z

trigger: test-robottelo
pytest: tests/foreman/foremanctl/test_install_foremanctl.py
deployment_type: container
theforeman:
  foremanctl: 726

Satellite-QE · 2026-08-05T18:34:43Z

PRT Result

Build Number: 16351
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/foremanctl/test_install_foremanctl.py --external-logging
Test Result : ======= 1 failed, 19 passed, 98 warnings, 1 error in 9559.35s (2:39:19) ========

evgeni · 2026-08-06T11:29:15Z

trigger: test-robottelo
pytest: tests/foreman/foremanctl/test_install_foremanctl.py
deployment_type: container
theforeman:
  foremanctl: 726

Satellite-QE · 2026-08-06T14:27:11Z

PRT Result

Build Number: 16354
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/foremanctl/test_install_foremanctl.py --external-logging
Test Result : ============ 20 passed, 97 warnings, 2 errors in 9957.23s (2:45:57) ============

evgeni · 2026-08-06T15:12:03Z

trigger: test-robottelo
pytest: tests/foreman/foremanctl/test_install_foremanctl.py
deployment_type: container
theforeman:
  foremanctl: 726

evgeni · 2026-08-07T06:42:34Z

The remaining error is ERROR at teardown of test_positive_foremanctl_auth_bundle[rhel9-ipv4-default] which seems unrelated to this change here

evgeni · 2026-08-07T06:55:33Z

The remaining error is ERROR at teardown of test_positive_foremanctl_auth_bundle[rhel9-ipv4-default] which seems unrelated to this change here

But it's failing to tear down a content host, and we don't need a content host here.

#22370

Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>

evgeni · 2026-08-07T11:24:22Z

trigger: test-robottelo
pytest: tests/foreman/foremanctl/test_install_foremanctl.py
deployment_type: container
theforeman:
  foremanctl: 726

Satellite-QE · 2026-08-07T14:48:49Z

PRT Result

Build Number: 16364
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/foremanctl/test_install_foremanctl.py --external-logging
Test Result : ================ 21 passed, 96 warnings in 11509.67s (3:11:49) =================

arvind4501 · 2026-08-11T11:29:11Z

Which SQL injection sourcery is complaining about https://github.com/SatelliteQE/robottelo/pull/22356/checks?check_run_id=92851528305 , i don't see any possibilities as such :strange

@sourcery-ai

Gauravtalreja1 · 2026-08-11T11:43:00Z

+        overrides_dir = '/usr/share/foremanctl/src/playbooks/_vendor_overrides/'
+        self.execute(f'mkdir -p {overrides_dir}/deploy/')
+        self.put(
+            'variables:\n  flavor:\n    choices:\n      - satellite',
+            f'{overrides_dir}/deploy/metadata.obsah.yaml',
+            temp_file=True,
+        )
+


Shouldn't this be handled in packaging instead of tests?

At some point it will. And then I'll remove it here.

I think we should create jira for it to track then use is_open('SAT-xxx') logic here for that so we don't need to handle that removal immediately

evgeni requested a review from a team as a code owner August 5, 2026 13:16

evgeni added the No-CherryPick PR doesnt need CherryPick to previous branches label Aug 5, 2026

github-actions Bot assigned evgeni Aug 5, 2026

sourcery-ai Bot reviewed Aug 5, 2026

View reviewed changes

Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Aug 5, 2026

evgeni requested a review from a team as a code owner August 5, 2026 15:45

shubhamsg199 mentioned this pull request Aug 6, 2026

Satellite flavor theforeman/foremanctl#726

Open

2 tasks

evgeni force-pushed the satellite-flavor branch 2 times, most recently from 39c292d to 30ff674 Compare August 6, 2026 11:28

evgeni force-pushed the satellite-flavor branch from 30ff674 to 4381a4b Compare August 6, 2026 15:09

shubhamsg199 approved these changes Aug 7, 2026

View reviewed changes

evgeni and others added 4 commits August 7, 2026 13:23

pass --flavor satellite when deploying using foremanctl

b8a6bcf

use bmc as the feature to enable/disable, rex is default

a1b6491

use_dynamic_inventories_wf_level=False

604a063

Signed-off-by: Shubham Ganar <shubhamsg123m@gmail.com>

override choices

4c7e822

evgeni force-pushed the satellite-flavor branch from 4381a4b to 4c7e822 Compare August 7, 2026 11:23

Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Aug 7, 2026

arvind4501 approved these changes Aug 11, 2026

View reviewed changes

Gauravtalreja1 reviewed Aug 11, 2026

View reviewed changes

Uh oh!

Conversation

evgeni commented Aug 5, 2026 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem Statement

Solution

Related Issues

Summary by Sourcery

Uh oh!

sourcery-ai Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Sequence diagram for Satellite installation via foremanctl with flavor option

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

evgeni commented Aug 5, 2026

Uh oh!

evgeni commented Aug 5, 2026

Uh oh!

Satellite-QE commented Aug 5, 2026

Uh oh!

evgeni commented Aug 5, 2026

Uh oh!

shubhamsg199 commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

evgeni commented Aug 5, 2026

Uh oh!

Satellite-QE commented Aug 5, 2026

Uh oh!

evgeni commented Aug 6, 2026

Uh oh!

Satellite-QE commented Aug 6, 2026

Uh oh!

evgeni commented Aug 6, 2026

Uh oh!

evgeni commented Aug 7, 2026

Uh oh!

evgeni commented Aug 7, 2026

Uh oh!

evgeni commented Aug 7, 2026

Uh oh!

Satellite-QE commented Aug 7, 2026

Uh oh!

arvind4501 commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gauravtalreja1 Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

evgeni Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

Gauravtalreja1 Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

evgeni commented Aug 5, 2026 •

edited by sourcery-ai Bot

Loading

sourcery-ai Bot commented Aug 5, 2026 •

edited

Loading

shubhamsg199 commented Aug 5, 2026 •

edited

Loading

arvind4501 commented Aug 11, 2026 •

edited

Loading