Fixing the missing markers as independent properties #13599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyejare
added
CherryPick
This was referenced Jan 4, 2024
| @@ -119,12 +119,15 @@ def pytest_collection_modifyitems(items, config): | |||
| markers_prop_data = [] | |||
| exclude_markers = ['parametrize', 'skipif', 'usefixtures', 'skip_if_not_set'] | |||
| for marker in item.iter_markers(): | |||
| prop = marker.name | |||
| if prop in exclude_markers: | |||
| proprty = marker.name | |||
There was a problem hiding this comment.
Its deliberately done as property is a reserved keyword in python :)
There was a problem hiding this comment.
Variable could be of any name though, including typing mistakes !
There was a problem hiding this comment.
PEP8 suggests to append a trailing underscore rather than introducing a spelling error in such cases
https://peps.python.org/pep-0008/#descriptive-naming-styles
...
single_trailing_underscore_: used by convention to avoid conflicts with Python keyword
github-actions bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
(cherry picked from commit ae99d0d)
This was referenced Jan 4, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
(cherry picked from commit ae99d0d)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
(cherry picked from commit ae99d0d)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
(cherry picked from commit ae99d0d)
jyejare
added a commit
that referenced
this pull request
Jan 5, 2024
jyejare
added a commit
that referenced
this pull request
Jan 5, 2024
jyejare
added a commit
that referenced
this pull request
Jan 5, 2024
jyejare
added a commit
that referenced
this pull request
Jan 5, 2024
shweta83
pushed a commit
to shweta83/robottelo
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
In PR #13043, Missed adding filtered markers as independent test properties impacting reporting tools like RP in reporting/filtering abilities.
Solution
This PR corrects that by adding only filtered markers as test properties.
Related Issues
No.