Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http-Proxy cacert automation coverage #11454

Merged
merged 2 commits into from
May 23, 2023
Merged

Http-Proxy cacert automation coverage #11454

merged 2 commits into from
May 23, 2023

Conversation

damoore044
Copy link
Contributor

@damoore044 damoore044 commented May 11, 2023 •
edited
Loading

-Automation for http-proxy cacert (found in Infrastructure>HttpProxy>New or edit proxy)
-The test aims to create or collect a valid cacert.crt, assign the cacert to an Http-Proxy, then sync a repo with the proxy.
-Depends on nailgun PR# 923: add cacert as a field of HttpProxy
-BZ# 2144044

@damoore044 damoore044 self-assigned this May 11, 2023
@damoore044 damoore044 added 6.13.z Introduced in or relating directly to Satellite 6.13 in progress This issue is being worked on labels May 11, 2023
@damoore044
Copy link
Contributor Author

damoore044 commented May 11, 2023 •
edited
Loading

The main issue with the test is on line 284, an exit code of 1 fails assertion for custom_cert_generate, indicating a script error may have occurred. Does anything stick out here?

@damoore044 damoore044 mentioned this pull request May 11, 2023
Merged
Griffin-Sullivan

This comment was marked as resolved.

Sign in to view

@damoore044

This comment was marked as resolved.

Sign in to view
@damoore044
Copy link
Contributor Author

damoore044 commented May 18, 2023 •
edited
Loading

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_sync_proxy_with_certificate
nailgun: 923

@damoore044 damoore044 changed the title Http-Proxy cacert automation coverage [WIP] Http-Proxy cacert automation coverage May 18, 2023
@damoore044 damoore044 added CherryPick PR needs CherryPick to previous branches and removed in progress This issue is being worked on labels May 18, 2023
@damoore044 damoore044 marked this pull request as ready for review May 18, 2023 15:55
@Griffin-Sullivan Griffin-Sullivan added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label May 18, 2023
@Griffin-Sullivan
Copy link
Contributor

BTW if you want to test the code quality check on your laptop before you push the changes you can run

# pre-commit run --all-files

@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_sync_proxy_with_certificate
nailgun: 923

@damoore044 damoore044 requested a review from a team May 22, 2023 13:02
@Satellite-QE Satellite-QE mentioned this pull request May 22, 2023
Merged
shubhamsg199
shubhamsg199 approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

Gauravtalreja1
Gauravtalreja1 approved these changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, with a few nitpick suggestions

tests/foreman/api/test_http_proxy.py Outdated Show resolved Hide resolved
tests/foreman/api/test_http_proxy.py Outdated Show resolved Hide resolved
tests/foreman/api/test_http_proxy.py Outdated Show resolved Hide resolved
ColeHiggins2
ColeHiggins2 approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK Pending comments

@Gauravtalreja1 Gauravtalreja1 merged commit d893cf4 into SatelliteQE:master May 23, 2023
@Satellite-QE Satellite-QE mentioned this pull request May 23, 2023
Merged
github-actions bot pushed a commit that referenced this pull request May 23, 2023
@damoore044 @web-flow
Http-Proxy cacert automation coverage (#11454)
b09bfeb 
* test_positive_sync_proxy_with_certificate

* Addressing comments

(cherry picked from commit d893cf4)
damoore044 added a commit that referenced this pull request Jun 1, 2023
@damoore044
Http-Proxy cacert automation coverage (#11454)
4452681 
* test_positive_sync_proxy_with_certificate

* Addressing comments

(cherry picked from commit d893cf4)
@damoore044
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_http_proxy.py -k test_positive_sync_proxy_with_certificate
nailgun: 923

ColeHiggins2 pushed a commit to ColeHiggins2/robottelo that referenced this pull request Oct 9, 2023
@damoore044 @ColeHiggins2
Http-Proxy cacert automation coverage (SatelliteQE#11454)
7e29155 
* test_positive_sync_proxy_with_certificate

* Addressing comments
shweta83 pushed a commit to shweta83/robottelo that referenced this pull request Apr 10, 2024
@damoore044 @shweta83
Http-Proxy cacert automation coverage (SatelliteQE#11454)
3151fec 
* test_positive_sync_proxy_with_certificate

* Addressing comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

@vsedmik vsedmik vsedmik approved these changes

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

Assignees

@damoore044 damoore044

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@damoore044 @Griffin-Sullivan @Gauravtalreja1 @ColeHiggins2 @vsedmik @shubhamsg199