Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the cherry pick GHA #930

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

omkarkhatavkar
Copy link
Contributor

Description of changes

Describe in detail the changes made, and any potential impacts to callers.

Upstream API documentation, plugin, or feature links

Link to any relevant upstream API documentation that relates to the content of the PR.

Functional demonstration

Provide an execution of the modified code, with ipython code blocks or screen shots.
You can exercise the code as raw API calls or using any other method.

Your contribution should include updates to the unit tests, covering the modified portions or adding new coverage.

Example:

# Demonstrate functional Snapshot read in ipython
In [1]: from nailgun.entities import Snapshot
In [2]: Snapshot(host='sat.instance.addr.com', id='snap_uuid').read()
Out [2]: <read method result>
Additional Information

Any additional notes for reviewers, comments about the change, TODO lists on WIP PRs, etc.

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (183828a) 92.18% compared to head (62719c1) 92.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #930   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files           6        6           
  Lines        3031     3031           
=======================================
  Hits         2794     2794           
  Misses        237      237           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jyejare jyejare merged commit cfed8c9 into SatelliteQE:master Jun 14, 2023
github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
(cherry picked from commit cfed8c9)
ogajduse pushed a commit that referenced this pull request Jun 23, 2023
(cherry picked from commit cfed8c9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.11.z 6.12.z 6.13.z 6.14.z CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants