Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade codecov dependency #914

Merged
merged 1 commit into from
May 2, 2023
Merged

Upgrade codecov dependency #914

merged 1 commit into from
May 2, 2023

Conversation

pnovotny
Copy link
Contributor

@pnovotny pnovotny commented Apr 14, 2023

codecov is no longer in PyPI.
UPDATE: codecov==2.1.12 has been removed from PyPI but developers uploaded
newer version 2.1.13 for those who still need it - like nailgun does.

More info:
https://about.codecov.io/blog/message-regarding-the-pypi-package/

@pnovotny pnovotny added CherryPick PR needs CherryPick to previous branches 6.13.z labels Apr 14, 2023
@pnovotny pnovotny self-assigned this Apr 14, 2023
@pnovotny pnovotny marked this pull request as ready for review April 14, 2023 15:37
@pnovotny pnovotny requested a review from a team April 14, 2023 15:37
@pnovotny
Copy link
Contributor Author

Ok, this looks like a stalemate. codecov package is no longer in PyPI, but nailgun uses it in the Code Quality (3.8) check - Test Nailgun Coverage.

@lhellebr
Copy link
Contributor

I don't have an opinion on whether we need it or not. But if we do, maybe get it from some other soure?

pondrejk
pondrejk previously approved these changes Apr 17, 2023
Copy link
Member

@jyejare jyejare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont remove the codecov package but just update the version to the latest one. The codecov is not entirely removed but they removed 2.1.12 version. So use 2.1.13 version

See my PR works for codecov installation https://github.com/SatelliteQE/nailgun/pull/915/files#diff-2b4945591edfeaa4cf4d3f155e66d4b43d1bda7a55d881d5cf3107f1b05abbbc

@jyejare
Copy link
Member

jyejare commented Apr 28, 2023

@pnovotny ping, see my last comment !

codecov==2.1.12 has been removed from PyPI but developers uploaded
newer version 2.1.13 for those who still need it - like nailgun does.

More info about the change:
https://about.codecov.io/blog/message-regarding-the-pypi-package/
@pnovotny pnovotny changed the title Remove codecov dependency Upgrade codecov dependency Apr 28, 2023
@pnovotny
Copy link
Contributor Author

@jyejare sorry for the late reply. Good news that they've kept the package. I've updated the requirements to codecov 2.1.13

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 25.00% and project coverage change: -1.52 ⚠️

Comparison is base (905eb11) 93.35% compared to head (cec37a0) 91.83%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
- Coverage   93.35%   91.83%   -1.52%     
==========================================
  Files           6        6              
  Lines        2933     3000      +67     
==========================================
+ Hits         2738     2755      +17     
- Misses        195      245      +50     
Impacted Files Coverage Δ
nailgun/entities.py 90.76% <25.00%> (-1.91%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jyejare
Copy link
Member

jyejare commented May 2, 2023

@pnovotny The codecov warning to fix the integration between this repo and code coverage upload is now enabled.

@jyejare
Copy link
Member

jyejare commented May 2, 2023

Merging this PR as its failing checks for other PRs.

@jyejare jyejare merged commit a3ab4e0 into master May 2, 2023
@jyejare jyejare deleted the remove-codecov-dependency branch May 2, 2023 07:24
github-actions bot pushed a commit that referenced this pull request May 2, 2023
codecov==2.1.12 has been removed from PyPI but developers uploaded
newer version 2.1.13 for those who still need it - like nailgun does.

More info about the change:
https://about.codecov.io/blog/message-regarding-the-pypi-package/

(cherry picked from commit a3ab4e0)
github-actions bot pushed a commit that referenced this pull request May 2, 2023
codecov==2.1.12 has been removed from PyPI but developers uploaded
newer version 2.1.13 for those who still need it - like nailgun does.

More info about the change:
https://about.codecov.io/blog/message-regarding-the-pypi-package/

(cherry picked from commit a3ab4e0)
github-actions bot pushed a commit that referenced this pull request May 2, 2023
codecov==2.1.12 has been removed from PyPI but developers uploaded
newer version 2.1.13 for those who still need it - like nailgun does.

More info about the change:
https://about.codecov.io/blog/message-regarding-the-pypi-package/

(cherry picked from commit a3ab4e0)
Gauravtalreja1 pushed a commit that referenced this pull request May 25, 2023
codecov==2.1.12 has been removed from PyPI but developers uploaded
newer version 2.1.13 for those who still need it - like nailgun does.

More info about the change:
https://about.codecov.io/blog/message-regarding-the-pypi-package/

(cherry picked from commit a3ab4e0)

Co-authored-by: Pavel Novotny <pnovotny@users.noreply.github.com>
Gauravtalreja1 pushed a commit that referenced this pull request May 25, 2023
codecov==2.1.12 has been removed from PyPI but developers uploaded
newer version 2.1.13 for those who still need it - like nailgun does.

More info about the change:
https://about.codecov.io/blog/message-regarding-the-pypi-package/

(cherry picked from commit a3ab4e0)

Co-authored-by: Pavel Novotny <pnovotny@users.noreply.github.com>
Gauravtalreja1 pushed a commit that referenced this pull request May 25, 2023
codecov==2.1.12 has been removed from PyPI but developers uploaded
newer version 2.1.13 for those who still need it - like nailgun does.

More info about the change:
https://about.codecov.io/blog/message-regarding-the-pypi-package/

(cherry picked from commit a3ab4e0)

Co-authored-by: Pavel Novotny <pnovotny@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.11.z 6.12.z 6.13.z CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants