Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fix for Networking tests #894

Merged

Conversation

shubhamsg199
Copy link
Contributor

@shubhamsg199 shubhamsg199 commented Feb 14, 2023

Description of changes

Adding choices for parameter_type field as it was populating random string for parameter_type causing Networking tests to fail

$ pytest tests/foreman/api/test_subnet.py
========================================= test session starts =================================================================
platform linux -- Python 3.11.1, pytest-7.2.1, pluggy-1.0.0
shared_function enabled - OFF - scope:  - storage: file
rootdir: /home/sganar/satellite/robottelo, configfile: pyproject.toml
plugins: xdist-3.1.0, services-2.2.1, mock-3.10.0, cov-3.0.0, reportportal-5.1.3, ibutsu-2.2.4
collected 47 items / 7 deselected / 40 selected                                                                                                                                                                                                                                          

tests/foreman/api/test_subnet.py ........................................                                                                                                                                                                                                          [100%]

================================= 40 passed, 7 deselected  in 157.55s (0:02:37) =======================================================

@shubhamsg199 shubhamsg199 self-assigned this Feb 14, 2023
@shubhamsg199 shubhamsg199 added CherryPick PR needs CherryPick to previous branches 6.12.z 6.13.z labels Feb 14, 2023
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_subnet.py

Copy link
Contributor

@shweta83 shweta83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@Gauravtalreja1 Gauravtalreja1 merged commit 1f2bca5 into SatelliteQE:master Feb 15, 2023
github-actions bot pushed a commit that referenced this pull request Feb 15, 2023
github-actions bot pushed a commit that referenced this pull request Feb 15, 2023
github-actions bot pushed a commit that referenced this pull request Feb 15, 2023
Gauravtalreja1 pushed a commit that referenced this pull request Feb 15, 2023
(cherry picked from commit 1f2bca5)

Co-authored-by: Shubham Ganar <67952129+shubhamsg199@users.noreply.github.com>
Gauravtalreja1 pushed a commit that referenced this pull request Feb 15, 2023
(cherry picked from commit 1f2bca5)

Co-authored-by: Shubham Ganar <67952129+shubhamsg199@users.noreply.github.com>
Gauravtalreja1 pushed a commit that referenced this pull request Feb 15, 2023
(cherry picked from commit 1f2bca5)

Co-authored-by: Shubham Ganar <67952129+shubhamsg199@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.11.z 6.12.z 6.13.z CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants