Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ahv_internal_debug option support for virt-who configuration #889

Merged

Conversation

yanpliu
Copy link
Contributor

@yanpliu yanpliu commented Feb 1, 2023

Description of changes

ahv_internal_debug option support for virt-who configuration

Upstream API documentation, plugin, or feature links

https:///apidoc/v2/configs/create.en.html

foreman_virt_who_configure_config[ahv_internal_debug]optional , nil allowed | Option Enable debugging output is required to enable AHV internal debug. It provides extra AHV debug information when both options are enabledValidations:Must be one of: true, false, 1, 0.
-- | --
Functional demonstration

Can create and update this option virt-who configuration
target_sat.api.VirtWhoConfig(**form_data).create()
virtwho_config.update(['ahv_internal_debug'])

Example:

target_sat.api.VirtWhoConfig(**form_data).create()
virtwho_config.update(['ahv_internal_debug'])
Additional Information

Test cases :PASS

(robottelo_vv) [yanpliu@yanpliu robottelo]$ pytest ./tests/foreman/virtwho/api/test_nutanix.py -k test_positive_ahv_internal_debug_option 
=============================================================================================== test session starts ===============================================================================================
platform linux -- Python 3.10.9, pytest-7.2.0, pluggy-1.0.0
shared_function enabled - OFF - scope:  - storage: file
rootdir: /home/yanpliu/gitrepository/robottelo, configfile: pyproject.toml
plugins: cov-3.0.0, xdist-3.1.0, services-2.2.1, mock-3.10.0, reportportal-5.1.3, ibutsu-2.2.4
collected 7 items / 13 deselected / -6 selected                                                                                                                                                                   

tests/foreman/virtwho/api/test_nutanix.py .                                                                                                                                                                 [100%]

================================================================================================ warnings summary =================================================================================================
tests/foreman/virtwho/api/test_nutanix.py::TestVirtWhoConfigforNutanix::test_positive_ahv_internal_debug_option
tests/foreman/virtwho/api/test_nutanix.py::TestVirtWhoConfigforNutanix::test_positive_ahv_internal_debug_option
tests/foreman/virtwho/api/test_nutanix.py::TestVirtWhoConfigforNutanix::test_positive_ahv_internal_debug_option
tests/foreman/virtwho/api/test_nutanix.py::TestVirtWhoConfigforNutanix::test_positive_ahv_internal_debug_option
tests/foreman/virtwho/api/test_nutanix.py::TestVirtWhoConfigforNutanix::test_positive_ahv_internal_debug_option
  /home/yanpliu/data/virtualenv_3_10_9/robottelo_vv/lib/python3.10/site-packages/urllib3/connectionpool.py:1045: InsecureRequestWarning: Unverified HTTPS request is being made to host 'dell-per740-68-vm-07.lab.eng.pek2.redhat.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============================================================================= 1 passed, 13 deselected, 5 warnings in 87.68s (0:01:27) =============================================================================

@yanpliu yanpliu self-assigned this Feb 1, 2023
@yanpliu yanpliu added 6.13.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR CherryPick PR needs CherryPick to previous branches labels Feb 1, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 93.35% // Head: 93.35% // No change to project coverage 👍

Coverage data is based on head (041c0dd) compared to base (1ebef7c).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #889   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files           6        6           
  Lines        2933     2933           
=======================================
  Hits         2738     2738           
  Misses        195      195           
Impacted Files Coverage Δ
nailgun/entities.py 92.67% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, please add zstream branch labels where this change is applicable, along with CherryPick label

Copy link
Contributor

@shubhamsg199 shubhamsg199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@Gauravtalreja1 Gauravtalreja1 merged commit 82a17e3 into SatelliteQE:master Mar 24, 2023
github-actions bot pushed a commit that referenced this pull request Mar 24, 2023
Gauravtalreja1 pushed a commit that referenced this pull request Mar 24, 2023
(cherry picked from commit 82a17e3)

Co-authored-by: yanpliu <yanpliu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Auto_Cherry_Picked GHA has automatically cherrypicked this PR CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants