Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for registration command packages #1225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for registration command packages #1225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nailgun/entities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6792,7 +6792,7 @@ def __init__(self, server_config=None, **kwargs):
'jwt_expiration': entity_fields.IntegerField(default=4),
'repo': entity_fields.StringField(default=''),
'repo_gpg_key_url': entity_fields.URLField(default=''),
'packages': entity_fields.ListField(default=[]),
'packages': entity_fields.StringField(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dosas Good catch, this field should only be a string field, but robottelo uses it as a list field only, will you be opening a PR for that too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't some tests be failing if packages was passed?

I cannot find any usage of packages in robottelo tests.

RegistrationCommand is called by api_register : https://github.com/search?q=repo%3ASatelliteQE%2Frobottelo%20api_register&type=code

'update_packages': entity_fields.BooleanField(default=False),
'force': entity_fields.BooleanField(default=False),
'ignore_subman_errors': entity_fields.BooleanField(default=False),
Expand Down