Skip to content

Commit

Permalink
Revert of Reenable WebrtcBrowserTest.CanMakeEmptyCallThenAddStreamsAn…
Browse files Browse the repository at this point in the history
…dRenegotiateEnable test again. (patchset #2 of https://codereview.chromium.org/254713004/)

Reason for revert:
Still failing:

http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/52254/steps/content_browsertests/logs/CanMakeEmptyCallThenAddStreamsAndRenegotiate

Original issue's description:
> Reenable WebrtcBrowserTest.CanMakeEmptyCallThenAddStreamsAndRenegotiateEnable test again.
> The underalying problem is now fixed. See http://crbug/293125 and  https://code.google.com/p/webrtc/source/detail?r=5870
>
> BUG=293125, 362431
>
> Committed: https://chromium.googlesource.com/chromium/src/+/b9a00c2caf679dfd2e97a3d6bbfd5e214609e1fc
TBR=perkj
NOTRY=true

Review URL: https://codereview.chromium.org/500963002

Cr-Commit-Position: refs/heads/master@{#291671}
  • Loading branch information
JensenPaul authored and Commit bot committed Aug 25, 2014
1 parent b39db9f commit 147bd4c
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion content/browser/media/webrtc_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,11 @@ IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest, MANUAL_CanSetupCallAndSendDtmf) {
MakeTypicalPeerConnectionCall("callAndSendDtmf(\'123,abc\');");
}

// TODO(phoglund): this test fails because the peer connection state will be
// stable in the second negotiation round rather than have-local-offer.
// http://crbug.com/293125.
IN_PROC_BROWSER_TEST_F(WebRtcBrowserTest,
CanMakeEmptyCallThenAddStreamsAndRenegotiate) {
DISABLED_CanMakeEmptyCallThenAddStreamsAndRenegotiate) {
const char* kJavascript =
"callEmptyThenAddOneStreamAndRenegotiate({video: true, audio: true});";
MakeTypicalPeerConnectionCall(kJavascript);
Expand Down

0 comments on commit 147bd4c

Please sign in to comment.