Skip to content

Use the new data loaders in the refactored data explorer. #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 67 commits into
base: refactor24-data-explorer
Choose a base branch
from
Open

Use the new data loaders in the refactored data explorer. #3492

wants to merge 67 commits into from

Conversation

jamescrake-merani
Copy link
Contributor

Previously, the 'load button' just loaded dummy data into the data explorer, but this PR hooks up the new data loaders in sasdata.

It also:

  • Provides a prototype data viewer which displays the data in a table
  • Hooks up the metadata viewer, and also makes some changes to it so it displays the metadata for ASCII files properly.
  • Implements the ASCII reader dialog as an 'advanced load' button in the File menu, as per this discussion

jamescrake-merani and others added 30 commits June 23, 2025 08:32
@jamescrake-merani
Add a dummy new data explorer.
f24a033 
To get the new data explorer to appear on the page.
@jamescrake-merani
Hook up an event for new perspective.
b4ffb03
@jamescrake-merani
File chooser for load data.
76ab33b 
Also includes a ruff format of the original file.
@jamescrake-merani
Load based on extension.
26a9311
@jamescrake-merani
Add all data files to the manager.
2dcc17c
@jamescrake-merani
End early on error.
2881004
@jamescrake-merani
Fixed some issues from the rebase.
f32eb5b
@jamescrake-merani
Missing method from the rebase.
b796902
@jamescrake-merani
I have no idea why this line was here.
7a9292e
@jamescrake-merani
Something weird has happened here.
d91c588
@jamescrake-merani
Fixed weird code getting removed.
edeff08
@jamescrake-merani
Support loading in ASCII files.
abbc52f
@jamescrake-merani
Full stop not needed here.
a5e19f8
@jamescrake-merani
Remove old imports.
4bac60d
@jamescrake-merani
Load ascii with default params.
54ab3fe 
Instead of using the dialog.
@jamescrake-merani
Pick out the sasdata object.
f14a042
@jamescrake-merani
Use the basename for this dict.
1a9e1ec
@jamescrake-merani
Initial data viewer dialog.
fbfd28e
@jamescrake-merani
Add filename label and layout.
4d16fed
@jamescrake-merani
Rename filenameLabel to nameLabel.
d747ced
@jamescrake-merani
Ruff format.
cc5a1f8
@jamescrake-merani
Removed unusued import.
3493f46
@jamescrake-merani
Ruff format.
4c7350a
@jamescrake-merani
Added the view data action.
114cb64
@jamescrake-merani
View data from the context menu.
792bc98
@jamescrake-merani
Add view data action to menu.
5de6199
@jamescrake-merani
Hook up event.
ecbd9f8
@jamescrake-merani
Fixed typo.
07f16dd
@jamescrake-merani
Set parent of layout properly.
57cbd2a
@jamescrake-merani
Use name for name label.
9590fd2
@jamescrake-merani jamescrake-merani added the Big Refactoring Project Refactoring project. These live in the sasview repo to have them all in the same place. label Jul 9, 2025
DrPaulSharp
DrPaulSharp reviewed Jul 14, 2025
View reviewed changes
Copy link
Contributor

@DrPaulSharp DrPaulSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alongside the issues we discussed on Friday, I have a couple of pernickety code suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrPaulSharp DrPaulSharp DrPaulSharp left review comments

Assignees
No one assigned
Labels
Big Refactoring Project Refactoring project. These live in the sasview repo to have them all in the same place.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamescrake-merani @DrPaulSharp