Test pdf viewing #3456
Draft
Test pdf viewing #3456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes were:
qtgui/Utilities/DocViewWidget.py/DocViewWidow
234+ settings.setAttribute(web_view.settings().PluginsEnabled, True)
235+ settings.setAttribute(web_view.settings().PdfViewerEnabled, True)
qtgui/MainWindow/GuiManager.py
1330 - webbrowser.open("https://www.sasview.org/docs/user/tutorial.html")
1330+ tutorialfile = “/user/tutorial.html”
1331 + self.showHelp(tutorialfilel)
Just had to capture the download request signal and accept it. However python files to not seem to actually download. Also our implementatin of QtWebEngine makes the download so silent the use thinks nothing is happening so added a logging.warning to force the log explorer open and a message generated
Note this does not enable the tutorials to be loaded into the viewer. They are still html programmed as forced downloaded somewhere in the build system
|
This now will render PDF links rather than downloading, as long as the html code does not force a download. The current build system/sphinx system are in fact coding the html for forced downloads. Whether viewing before downloading is preferable is also a question given that downloading from the viewer is not obvious (requires the context sensitive right click menu). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to see if loading PDF into Qt browser will make things easier
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licencing (untick if necessary)