Skip to content

Conversation

@krzywon
Copy link
Contributor

@krzywon krzywon commented Jan 2, 2025

Description

This circumvents the fitting issue related to the recent changes in the bumps package that require parameter values to be floats, where SasView has been using uncertanties objects. The Parameter object has an optional attribute called slot introduced in v1.* that I am using here instead. This attribute does not exist in v0.9.3 of bumps, but the way I am using it creates a new attribute of the parameter, maintaining backward compatibility.

Fixes #3109
Fixes #3227

How Has This Been Tested?

Tested locally using both bumps v0.9.3 and v1.0.0a10. Fits (and subsequent fits in the same tab) are successful for both versions of bumps.

Review Checklist:

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)

Licencing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@butlerpd butlerpd added the Discuss At The Call Issues to be discussed at the fortnightly call label Jan 13, 2025
@jamescrake-merani jamescrake-merani self-requested a review March 11, 2025 14:38
Copy link
Contributor

@jamescrake-merani jamescrake-merani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me, and works on my machine.

@jamescrake-merani jamescrake-merani merged commit 66af1e8 into main Mar 13, 2025
19 checks passed
@jamescrake-merani jamescrake-merani deleted the 3109-bumps-parameter branch March 13, 2025 09:07
@krzywon krzywon mentioned this pull request May 9, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Discuss At The Call Issues to be discussed at the fortnightly call

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Matplotlib Error when using the DREAM fit algorithm Bumps master branch no longer compatible with SasView

5 participants