Adds Pyupgrade (UP) ruleset to ruff linter #661
Conversation
jamescrake-merani
left a comment
jamescrake-merani
left a comment
There was a problem hiding this comment.
I'm approving but take a quick look at the comments, and then merge if you're happy.
| @@ -37,8 +34,6 @@ | |||
| QC_ONLY = True # show only what is needed for dqc in the symmetric case | |||
|
|
|||
| # include unicode symbols in output, even if piping to a pager | |||
There was a problem hiding this comment.
Is this comment still needed now?
There was a problem hiding this comment.
Yes, I think so, because the init_printing routine is there to allow printing unicode characters.
| from docutils.writers.html4css1 import HTMLTranslator | ||
| from docutils.nodes import SkipNode | ||
|
|
||
| # pylint: disable=unused-import |
There was a problem hiding this comment.
I hesitated a bit when I saw that we previously disabled this unused import warning, but now I think about it, I think we already solved this problem by bumping the minimum Python version. So I don't think this is needed.
There was a problem hiding this comment.
The import of Tuple is only used for a single type hint, and we're switching to using tuple instead of typing.Tuple throughout the code, so I'm happy that we're ok here.
| def load_sasfit(path): | ||
| data = np.loadtxt(path, dtype=str, delimiter=';').T | ||
| data = np.vstack((map(float, v) for v in data[0:2])) | ||
| data = np.vstack(map(float, v) for v in data[0:2]) |
There was a problem hiding this comment.
This should be failing. For version 2.2.6 that I happen to have installed, np.vstack(generator) gives
TypeError: arrays to stack must be passed as a "sequence" type such as list or tuple.
This is a bug in the original, which should have used [...] rather than (...) when forming the sequence to send to vstack, so not an error introduced by this PR.
There was a problem hiding this comment.
Thanks for letting me know, I'll put in a one-liner PR to correct this.
No description provided.