Skip to content

Conversation

@pkienzle
Copy link
Contributor

Fixes #618

@pkienzle
Copy link
Contributor Author

Note that romberg has been dropped from scipy integrate so this was replaced by quad in the validation tests, but quad doesn't converge so the tests fail.

These are slow validation tests that do not need to be run during CI, so suppress them for now. This does not change test coverage.

Consider moving the validation tests to the "explore" directory with other validation code.

Revisit when we address #568.

@pkienzle pkienzle requested a review from bmaranville January 13, 2025 16:43
cylinder = Cylinder()
return cylinder.evalDistribution([0.1, 0.1])
# Smoke test: does it run without error?
cylinder.evalDistribution([0.1, 0.1])
Copy link
Contributor

@bmaranville bmaranville Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you not want to assert a known, expected returned value for evalDistribution here?

pytest.ini Outdated
doctest_optionflags = ELLIPSIS
testpaths = sasmodels
python_files = *.py
python_files = doc/**/*.py example/**/*.py sasmodels/**/*.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is a good idea - seems appropriate to test the python files in this library, not every library that this library uses.

@pkienzle
Copy link
Contributor Author

After removing doc from the glob I tried to make sure that doctests were still being run on the rst files in the doc directory. Turns out that they aren't, and there aren't any except for a spurious shell command doc written as >>>. I changed it to > like the others in that file. For linux I would have used $ instead of >. Not sure what the convention is for windows.

@krzywon krzywon merged commit 736e214 into master Jan 16, 2025
18 checks passed
@krzywon krzywon deleted the 618_scipy_1_15 branch January 16, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Latest scipy (1.15) will make pytest tests fail

5 participants