-
Notifications
You must be signed in to change notification settings - Fork 30
Use tccbox instead of tinycc #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It seems we should hold off on this till the bug fix release branch is made. |
|
It looks like comments from the review have been resolved. @krzywon is this ready to merge? |
|
Assuming the latest CI passes, I think this is ready now. All OSes are now requiring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI has passed, and everything else LGTM so I am approving this PR. We can add tccbox to requirements later if the Wheels work isn't ready by the code freeze.
This is the first step to tcc support in MacOS. Currently all tests pass using single and double precision, GPU and CPU. A few includes are required that are still being finalized.