Skip to content

Conversation

@krzywon
Copy link
Collaborator

@krzywon krzywon commented Dec 3, 2024

This is the first step to tcc support in MacOS. Currently all tests pass using single and double precision, GPU and CPU. A few includes are required that are still being finalized.

@butlerpd
Copy link
Member

It seems we should hold off on this till the bug fix release branch is made.

@jamescrake-merani
Copy link
Contributor

It looks like comments from the review have been resolved. @krzywon is this ready to merge?

@krzywon
Copy link
Collaborator Author

krzywon commented Apr 9, 2025

Assuming the latest CI passes, I think this is ready now. All OSes are now requiring tccbox as a part of setup.py. The last thing I might need to do is add the tccbox package to the sasview requirements, but that will only be required if the wheels work isn't ready.

Copy link
Contributor

@jamescrake-merani jamescrake-merani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI has passed, and everything else LGTM so I am approving this PR. We can add tccbox to requirements later if the Wheels work isn't ready by the code freeze.

@krzywon krzywon merged commit 7a1bdb7 into master Apr 11, 2025
18 checks passed
@krzywon krzywon deleted the tccbox branch April 11, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants