Repository navigation
fix(deps): drop the duplicated source-map-js override that broke installs - #71
Merged
Merged
Conversation
…alls #69 and #70 each added a source-map-js ^1.2.2 override for the same advisory and merged a minute apart. Git combined them without a conflict: package.json gained the key twice, and pnpm-lock.yaml's overrides block a duplicated mapping key, which pnpm refuses (ERR_PNPM_BROKEN_LOCKFILE), so every CI job on main failed at install and so would any fresh checkout. Keeps the copy in alphabetical position; package.json is again the file #69 shipped. pnpm install --frozen-lockfile and pnpm audit --audit-level=high both pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maincan't install, and every CI job fails at setup:ERR_PNPM_BROKEN_LOCKFILE … duplicated mapping key (43:3).#69 and #70 each added a
source-map-js: ^1.2.2override for the same advisory. #70's is commit a94554b. They merged a minute apart, and Git combined them without a conflict, leaving the key twice in bothpackage.jsonandpnpm-lock.yaml. JSON tolerates the duplicate; the lockfile's YAML doesn't, so pnpm refuses it.This keeps the copy in alphabetical position and removes the other from both files.
package.jsonis again exactly the file #69 shipped.Verification, run on today's
mainplus this fix:pnpm install --frozen-lockfilepasses.pnpm audit --audit-level=highpasses.TURBO_FORCE=true pnpm testpasses 11,847 tests, with nothing cached. This is the first full run that includes Limit Gmail category mapping to Promotions and protect Spam #70's code, becausemain's CI couldn't install after it merged.pnpm type-checkandpnpm lintpass.Avoiding a repeat: GitHub merged two PRs that each passed alone but break together. Turning on Require branches to be up to date before merging (or a merge queue) in the
mainruleset makes every merge re-run CI on the combined result.🤖 Generated with Claude Code