Implement the main part of the xref interface #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sarcasm
reviewed
Oct 29, 2018
| @@ -426,6 +428,7 @@ If no such file exists on the filesystem the special file '-' is | |||
| (display-warning 'irony "Performance will be bad because a\ | |||
| pipe delay is set for this platform (see variable\ | |||
| `w32-pipe-read-delay').")))) | |||
| (irony-xref--enter) | |||
There was a problem hiding this comment.
Should this be optional?
I think some people use irony for completion only, and sometime use rtags or something else for cross reference.
| (irony-iotask-package-task irony--t-xref-references | ||
| (car line-column) (cdr line-column)))))) | ||
| (cl-loop for item in result | ||
| do (message "%S" item)))) |
| @@ -14,6 +14,8 @@ include(CTest) | |||
| check_for_in_source_build() | |||
| release_as_default_build_type() | |||
|
|
|||
| set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -g -O0 -fsanitize=address -fsanitize=undefined -Weverything -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-padded -Wno-missing-prototypes -Wno-shadow-field-in-constructor") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left for a while and completely forgot #384.
For the xref interface see https://github.com/emacs-mirror/emacs/blob/master/lisp/progmodes/xref.el, and the lisp xref backend in https://github.com/emacs-mirror/emacs/blob/master/lisp/progmodes/elisp-mode.el
This implements
xref-find-{definitions,references}. It's not quite perfectfind-referencesfunctionality seems a little wonky: it seems to find references to the thing at point only in the same file plus the file in which it is defined (?). Maybe I got the AST traversal logic wrong inIrony::xrefReferences, but I'm not sure.There are several FIXME's left in the code, which may or may not be issues (please have a look), they were things I wasn't quite sure about.
I tested this in my own code, it seems to work, but I don't have any actual unit tests for it.