Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use dart core sort to improve sortBy performance on Iterable<T> #101

Merged
merged 1 commit into from
Apr 28, 2023
Merged

use dart core sort to improve sortBy performance on Iterable<T> #101

merged 1 commit into from
Apr 28, 2023

Conversation

hbock-42
Copy link
Contributor

@SandroMaglione SandroMaglione linked an issue Apr 28, 2023 that may be closed by this pull request
fpdart sortBy is very slow and time processing scales very quickly #100
Closed
@SandroMaglione SandroMaglione added the refactoring No change in functionality, but rewrite of some code label Apr 28, 2023
@SandroMaglione SandroMaglione merged commit 74dec82 into SandroMaglione:main Apr 28, 2023
kabirnayeem99
kabirnayeem99 reviewed May 6, 2023
View reviewed changes
Copy link

@kabirnayeem99 kabirnayeem99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabirnayeem99 kabirnayeem99 kabirnayeem99 left review comments

Assignees
No one assigned
Labels
refactoring No change in functionality, but rewrite of some code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fpdart sortBy is very slow and time processing scales very quickly
3 participants
@hbock-42 @kabirnayeem99 @SandroMaglione