Fixing is_clang wrongly returning false on macOS #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is_clang returns ‘false’ if cc() returns a full path to the clang executable (e.g., CC=$(xcrun --find clang), causing the driver function cc() to return “/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang”). This fix does the same comparison as before, but on the token at the end of the full path.
|
Ah, could you modify the PR so that it uses char *ptr = strrchr(cc, UT_OS_PS); // ptr now points to the last occurrence of / or \
|
Removes unneccesary loop and malloc. Currently assumes that path separator is a single byte in size.
Tested against the following strings:
```c
const char *test_strings[22] = {
"clang",
"clang ",
" clang ",
"./clang",
".\\clang",
"clang++",
"clang++ ",
" clang++ ",
"./clang++",
".\\clang++",
"/clang/",
"/clang++/",
"\\clang++\\",
"clang/gcc",
"clang/g++",
"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang",
" ",
"",
"\\",
"/",
NULL,
"\0"
};
```
|
Ooh, yes, that's great! I pushed an update 🙂 Thanks for checking, @SanderMertens! |
SanderMertens
force-pushed
the
master
branch
2 times, most recently
from
25afe73 to
44374c9
Compare
|
I just merged your change with master (not sure why it's not showing up here). I tweaked it a little bit so that your fix can be used for all compilers. Thanks again! (and sorry again for being so late- not sure if "late" even covers it anymore :p) |
|
For ref, this is what the code looks like now: https://github.com/SanderMertens/bake/blob/master/drivers/lang/c/src/gcc/driver.c#L73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_clang returns ‘false’ if cc() returns a full path to the clang executable (e.g., CC=$(xcrun --find clang), causing the driver function cc() to return “/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang”).
This fix does the same comparison as before, but on the token at the end of the full path.