Pr gint test #1
Merged
Pr gint test #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to ensure they comply with the limits of the nameslist.
Changes to add support to 360-day and 365-day (no leap year) calendar - see ticket NOAA-EMC#209 * Additional CALTYPE namelist parameter in MISC section * New ww3_tc1 regtest.
* Updated ww3_bound and ww3_bounc to handle model grids formulated on a rotated pole. * Manual and nml/inp files to updated clarify that ww3_bound/ww3_bounc only accept input spectra formulated on a standard pole grid.
Updates to allow a coupling time step that is different from the model time step. * Includes new regtest (in ww3_tp2.14) for non-default oasis time step. * ww3_tp2.14 regtest added to matrix.base.
* Create pull_request_template.md
* Update issues templates for enhancement, documentation, bug report and suggestion
* First set of changes intended to fix the bug (NOAA-EMC#19) Fixes: NOAA-EMC#314 * Interpolation weights now correctly calculated on points next to land and BC locations. * Changes to improve the code: the possibility of reading zero values from the input is considered, and points that should not be taken into account in the interpolation are identified by the netcdf fill value; a subroutine is created to avoid code duplication * Bug fix and small simplification/optimization change (NOAA-EMC#18) * Fixes NOAA-EMC#290 (ww3_multi hanging when generating restart with IOSTYP >= 2) * Also fixes out-of-bounds array access error. * Includes some MPI optimizations * Correction to the bug fix in branch bf_multi_hang to take into account the coupled configurations, that are also affected * Small correction to the multi_hang branch: revert changes to JSEA index in w3iorsmd Co-authored-by: Juan Manuel Castillo Sanchez <48921434+ukmo-juan-castillo@users.noreply.github.com> Co-authored-by: ukmo-juan.castillo <juan.m.castillo@metoffice.gov.uk>
* Added boundary checks to the SMC grid input files for ww3_grid, to ensure they comply with the limits of the nameslist. * Fb 360 calendar (NOAA-EMC#8) Changes to add support to 360-day and 365-day (no leap year) calendar - see ticket NOAA-EMC#209 * Additional CALTYPE namelist parameter in MISC section * New ww3_tc1 regtest. * RTD support for ww3_boun[dc] (NOAA-EMC#10) * Updated ww3_bound and ww3_bounc to handle model grids formulated on a rotated pole. * Manual and nml/inp files to updated clarify that ww3_bound/ww3_bounc only accept input spectra formulated on a standard pole grid. * Fb coupling time (NOAA-EMC#9) Updates to allow a coupling time step that is different from the model time step. * Includes new regtest (in ww3_tp2.14) for non-default oasis time step. * ww3_tp2.14 regtest added to matrix.base. * bug fix for ukmet development * Periodicity fix for global unstructured grids - Corrects calculation of element areas and edge lengths across the dateline in w3triamd.ftn - Fixes calculation to determine whether a point is inside an element that spans the dateline in w3triamd.ftn - Corrects calculation of element centers and corners across dateline in wmscrpmd.ftn - Write out SCRIP file in netCDF format at the end of ww3_grid (for creating offline remaping files). This required adding netCDF support to ww3_grid - Also includes minor fix for the /O7a switch in w3iopomd.ftn * modify the model/ftn/w3triamd.ftn and model/ftn/wmscrpmd.ftn and change from global grids from min(longitude)=-180, max(longitude)=180 to \delta(longitude)=360 degrees and added the regression test ww3_tp2.21 * bug fix for ww3_grid make without SCRIP switch * Fix for corner node periodicity in wmscrpmd.ftn * PDLIB/yowpdlibmain.ftn: fix to handle global meshes * bug fix for SCRIPNC switch * update info for ww3_tp2.21 for domain decomposition and PDLIB option * fix for mww3_04 link with SCRIP and SCRIPNC switch * add inputs to tar file, update model/bin/ww3_from_ftp.sh and remove inputs from ww3_tp2.21 * reduce the duration of ww3_tp2.21 for the sake of regtest time * small editorial fixes * fixes for SCRIPNC switch * change date for ww3_ounf and ww3_ounp for ww3_tp2.21 * edit w3_make Co-authored-by: lewis.sampson <lsampson@vld240.cmpd1.metoffice.gov.uk> Co-authored-by: Juan Manuel Castillo Sanchez <48921434+ukmo-juan-castillo@users.noreply.github.com> Co-authored-by: Chris Bunney <48915820+ukmo-ccbunney@users.noreply.github.com> Co-authored-by: Ali Abdolali <aliabdolali@Alis-MBP.fios-router.home> Co-authored-by: Steven Brus <sbrus@lanl.gov> Co-authored-by: Steven Brus <steven.r.brus@gmail.com> Co-authored-by: Lorenzo Mentaschi <lorenzo.mentaschi@unige.it>
* Added boundary checks to the SMC grid input files for ww3_grid, to ensure they comply with the limits of the nameslist. * Fb 360 calendar (NOAA-EMC#8) Changes to add support to 360-day and 365-day (no leap year) calendar - see ticket NOAA-EMC#209 * Additional CALTYPE namelist parameter in MISC section * New ww3_tc1 regtest. * RTD support for ww3_boun[dc] (NOAA-EMC#10) * Updated ww3_bound and ww3_bounc to handle model grids formulated on a rotated pole. * Manual and nml/inp files to updated clarify that ww3_bound/ww3_bounc only accept input spectra formulated on a standard pole grid. * Fb coupling time (NOAA-EMC#9) Updates to allow a coupling time step that is different from the model time step. * Includes new regtest (in ww3_tp2.14) for non-default oasis time step. * ww3_tp2.14 regtest added to matrix.base. * bug fix for ukmet development * add the matrix subsetter * clean-up * clean up * add another script which separate serial and parallel jobs and divide them * modify the script to remove ../model? after test completion. * bug fixes and adding ww3_tp2.17 to list_heavy * add if statement to remove matrix? and model? * Update matrix_divider_p.sh * Merge remote-tracking branch 'upstream/develop' into fb_matrix_divider * Merge remote-tracking branch 'upstream/develop' into fb_matrix_divider * put if check for ../model? inside matrix? loop * fix the bug for sed for model? * final fix for extra model? removal * add 2.21 to the list_heavy Co-authored-by: lewis.sampson <lsampson@vld240.cmpd1.metoffice.gov.uk> Co-authored-by: Juan Manuel Castillo Sanchez <48921434+ukmo-juan-castillo@users.noreply.github.com> Co-authored-by: Chris Bunney <48915820+ukmo-ccbunney@users.noreply.github.com> Co-authored-by: Ali Abdolali <aliabdolali@Alis-MBP.fios-router.home>
* updates for NetCDF comp/linking Issue NOAA-EMC#332 fixes from @aerorahul * Updating matrix_ncep to use hpc-stack modules * update path for orion hpc-stack and change np, nr, nth * add module purge and revert 8->24 * update NetCDF in ww3_tp2.14 oasis test makefile
* 🐛 inconsistent check and deallocation * ⭐ improved tidal output around equator * 🐛 TIDECON_NAME and TIDE_FREQC are not deallocated/allocated as pairs * ♻️ restored TIDECON_NAME allocation/deallocation Co-authored-by: sanderh <sander.hulst@dtn.com>
* Changes to fix issue NOAA-EMC#341 * Fix the bug in a different way, as with the previous solution the information read from the restart file is wrongly overwritten
Co-authored-by: Ali <ali.abdolali@noaa.gov>
* Insertion of the PDLIB stuff. Mathieu * bug in SIGN call when SCRIP is activated * update SIGN issue Co-authored-by: Mathieu Dutour Sikiric <Mathieu.Dutour@gmail.com> Co-authored-by: erdc-tyler.hesser <tyler.hesser@erdc.dren.mil>
… into PR_gint_test
|
Hi @SanderHulst |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The noaa/develop is merged to this PR.
ww3_multi and ww3_gint are added to the ww3_tp2.21 (globa unstrucured).
Two tests are added for ww3_tp2.21:
1- ww3_gint with interpolation option 1
1- ww3_gint with interpolation option 2