fix: only parse time & seeking from TagPackets for Hide&Seek or Sardines #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 4) WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 37) WARN: FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 4)
Freeze-Tag uses the same `UpdateType` flags for some of its `TagPacket`s as H&S and Sardines do. But Freeze-Tag has another packet data structure that isn't matching IsIt, Seconds and Minutes. Therefore the server wrongly interprets Freeze-Tag packets and updates its "seeking" and "time" metadata wrongly. (These metadata fields are used to resend the `TagPacket` to later joining clients.) This commit does the following changes: - add: game mode detection in the first 4 bit of the `TagPacket.UpdateType` - change: parse the `TagPacket` for the metadata iff it is clearly for H&S or Sardines - change: only resend `TagPacket` to new clients for H&S or Sardines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Freeze-Tag uses the same
UpdateTypeflags for some of itsTagPackets as H&S and Sardines do.But Freeze-Tag has another packet data structure that isn't matching
IsIt,SecondsandMinutes.Therefore the server wrongly interprets Freeze-Tag packets and updates its
"seeking"and"time"metadata wrongly.(These metadata fields are used to resend the
TagPacketto later joining clients.)This PR does the following changes:
.github/workflows/to the newest versionsDockerfileto avoid 3 warning messagesTagPacket.UpdateTypeTagPacketfor the metadata iff it is clearly for H&S or SardinesTagPacketto new clients for H&S or Sardines