fix: construct tag packet instead of caching it in memory #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the tag packet received from the client could have an UpdateType that isn't both State and Time. (Though currently the client always updates both together.)
Sanae6
approved these changes
Apr 27, 2024
Istador
added a commit
to Istador/smo-multi-rs
that referenced
this pull request
May 4, 2024
- Send empty `TagPacket` and `CapturePacket` on new connections, to reset old data back that other players might still have in their puppet from an earlier connection. - Cache and send `CostumePacket`, `CapturePacket`, `GamePacket` and `PlayerPacket` to (re-)connecting players. Same change in the C# server: - Sanae6/SmoOnlineServer#49 --- The last `TagPacket` is not cached, because it could contain an update type that isn't complete. Instead a packet is created from `time` and `is_seeking` for (re-)connecting players. Same change in the C# server: - Sanae6/SmoOnlineServer#52 --- As this server deletes the player data on disconnects, the cached packets from earlier re-connected connections are no longer available. Therefore the saved packets don't need to be cleared for fresh connections (after a restart). --- But this can cause sync issues for new players now, if ealier re-connecting players use a mod version below 1.3.0. Because the mod below 1.3.0 does not send all of the important game packets again after a reconnect. I'm ignoring this for now, because version 1.4.0 of the mod is required to connect to a UDP server that has a fix for this. But if this rust server software is used for TCP-only a client with an older mod version might connect and run into these issues. For now I've added two TODO comments in `client.rs` and `coordninator.rs` to mark where a change is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the tag packet received from the client could have an
UpdateTypethat isn't bothStateandTime. (Though currently the client always updates both together.)