Repository navigation
fix(deps): upgrade vitest to 4.1.11 and pin fflate - #2
Merged
Merged
Conversation
vitest/@vitest/mocker < 4.1.11 allow path traversal through redirect mocks (no 3.x fix). Vitest 4 requires constructor mocks to be regular functions, so the ZshInstaller mocks drop their arrow implementations. Also overrides fflate (via @vitest/ui) past its unzipSync infinite loop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Update the flake.nix dependency hash to match the refreshed lockfile.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Upgrades Vitest to address security vulnerabilities and updates related mocks and dependencies.
Changes:
- Upgrade
vitestand@vitest/uito^4.1.11. - Update ZshInstaller mocks for Vitest 4.
- Override
fflateto a secure version.
| File | Summary |
|---|---|
test/commands/completion.test.ts |
Updates constructor-compatible mocks. |
pnpm-workspace.yaml |
Adds the fflate security override. |
pnpm-lock.yaml |
Refreshes dependencies; requires the corresponding flake.nix fetch hash update. |
package.json |
Upgrades Vitest dependencies. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+60
to
+61
| specifier: ^4.1.11 | ||
| version: 4.1.11(vitest@4.1.11) |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SanHsien
added a commit
that referenced
this pull request
Sep 28, 2026
…26-09-28 Triage upstream PRs Fission-AI#1990-Fission-AI#1991 and issues Fission-AI#1988-Fission-AI#1989. Update REVIEW.md, DECISIONS.md, HANDOFF.md, and upstream_baseline.json. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Dependabot alerts #1, #3, Fission-AI#4 (vitest / @vitest/mocker path traversal, fixed only in 4.1.11).
new; switched the three ZshInstaller mocks tofunction () { return {...} }(same objects).Local:
pnpm test4488 passed / 79 skipped (same as before),pnpm lintandpnpm buildclean,pnpm auditno known vulnerabilities.🤖 Generated with Claude Code