Skip to content

Conversation

@odidev
Copy link
Contributor

@odidev odidev commented May 4, 2021

Added linux aarch64 wheel build support.
Related to #65. @polm Could you please review this PR?

@polm
Copy link
Collaborator

polm commented May 5, 2021

Thanks, this would be a great feature to have! I'm kind of busy this week but I'll take a look at this soon.

@polm
Copy link
Collaborator

polm commented May 18, 2021

Sorry it took me a while to get to this. I have a Raspi I thought I could test this on but turns out it's a bit too old to be aarch64.

Your changes look fine, so what I'll do is merge them and do a test release.

Thanks again for the PR!

@polm polm merged commit 981abb9 into SamuraiT:master May 18, 2021
@polm
Copy link
Collaborator

polm commented May 18, 2021

In an incredible stroke of bad luck it seems Github Actions is having issues tonight, I'll check out the results later.

@polm
Copy link
Collaborator

polm commented May 19, 2021

An alpha release is up and running and can be installed with this command:

pip install mecab-python3==1.0.4a2

Can you confirm that works for you?

For the record, one change I had to make was disabling building wheels with Python 3.5, which doesn't seem to be supported any more.

@odidev
Copy link
Contributor Author

odidev commented May 19, 2021

An alpha release is up and running and can be installed with this command:

pip install mecab-python3==1.0.4a2

Can you confirm that works for you?

For the record, one change I had to make was disabling building wheels with Python 3.5, which doesn't seem to be supported any more.

@polm, Thanks. I installed the aarch64 using pip install mecab-python3==1.0.4a2 and it is working as expected. Below are the installation logs:

ubuntu@1pthunderx1-137:~$ pip3 install mecab-python3==1.0.4a2
Defaulting to user installation because normal site-packages is not writeable
Looking in indexes: https://pypi.org/simple, https://packagecloud.io/abeja/platform-public/pypi/simple
Collecting mecab-python3==1.0.4a2
  Downloading mecab_python3-1.0.4a2-cp38-cp38-manylinux_2_17_aarch64.manylinux2014_aarch64.whl (555 kB)
     |████████████████████████████████| 555 kB 7.0 MB/s
Installing collected packages: mecab-python3
Successfully installed mecab-python3-1.0.4a2
ubuntu@1pthunderx1-137:~$
ubuntu@1pthunderx1-137:~$ uname -m
aarch64

@polm
Copy link
Collaborator

polm commented May 20, 2021

Thanks, I had another user install it successfully on arm64 Linux so I guess this works. Thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants