Move COLLADA fix to dedicated module

source/universal_importer/collada.rb

@@ -25,7 +25,6 @@ module COLLADA
     # Because SketchUp imports DAE files with generic materials names, e.g. `<auto>1`
     #
     # @param [Hash] materials_name Materials names indexed by texture path or color.
-    #
     # @raise [ArgumentError]
     def self.fix_materials_names(materials_names)
 
@@ -48,6 +47,29 @@ def self.fix_materials_names(materials_names)
 
     end
 
+    # Fixes the double sided faces in a DAE file to import in SketchUp.
+    # @see https://github.com/SketchUp/api-issue-tracker/issues/414
+    #
+    # @param [String] dae_file_path Absolute path to the DAE file to fix.
+    # @raise [ArgumentError]
+    def self.fix_double_sided_faces(dae_file_path)
+
+      raise ArgumentError, 'dae_file_path must be a String' \
+        unless dae_file_path.is_a?(String)
+
+      dae_file_contents = File.read(dae_file_path)
+
+      # Thanks to Piotr Rachtan for this workaround.
+      faces_fix = '<extra><technique profile="GOOGLEEARTH">'
+      faces_fix += '<double_sided>1</double_sided>'
+      faces_fix += "</technique></extra>\n</profile_COMMON>"
+
+      dae_file_contents.gsub!('</profile_COMMON>', faces_fix)
+
+      File.write(dae_file_path, dae_file_contents)
+
+    end
+
   end
 
 end

source/universal_importer/import.rb

@@ -18,6 +18,7 @@
 require 'universal_importer/assimp'
 require 'universal_importer/mtl'
 require 'universal_importer/meshlab'
+require 'universal_importer/collada'
 require 'universal_importer/donate'
 
 # Universal Importer plugin namespace.
@@ -112,7 +113,7 @@ def initialize()
       end
 
       convert_intermediate_to_final
-      fix_faces_in_final_dae
+      COLLADA.fix_double_sided_faces(@final_dae_file_path)
       Sketchup.active_model.import(@final_dae_file_path)
 
       # From now, SketchUp waits for user to place imported model as component.
@@ -404,25 +405,6 @@ def convert_intermediate_to_final
 
     end
 
-    # Fixes double sided faces in final DAE file.
-    def fix_faces_in_final_dae
-
-      final_dae = File.read(@final_dae_file_path)
-
-      final_dae.insert(0, "<!-- File modified by Universal Importer plugin for SketchUp. -->\n")
-
-      # Thanks to Piotr Rachtan for workaround.
-      # @see https://github.com/SketchUp/api-issue-tracker/issues/414
-      faces_fix = '<extra><technique profile="GOOGLEEARTH">'
-      faces_fix += '<double_sided>1</double_sided>'
-      faces_fix += "</technique></extra>\n</profile_COMMON>"
-
-      final_dae.gsub!('</profile_COMMON>', faces_fix)
-
-      File.write(@final_dae_file_path, final_dae)
-
-    end
-
     # Increments "imports.count" file.
     def self.increment_counter
 

source/universal_importer/poly_reduction.rb

@@ -17,6 +17,7 @@
 require 'universal_importer/assimp'
 require 'universal_importer/mtl'
 require 'universal_importer/meshlab'
+require 'universal_importer/collada'
 
 # Universal Importer plugin namespace.
 module UniversalImporter
@@ -67,7 +68,7 @@ def initialize
       apply_polygon_reduction
 
       convert_from_obj_to_dae
-      fix_faces_in_dae_import
+      COLLADA.fix_double_sided_faces(@dae_import_file_path)
       convert_from_dae_to_skp
 
       @completed = true
@@ -189,23 +190,6 @@ def convert_from_obj_to_dae
       @dae_import_file_path = File.join(@temp_dir, 'import.dae')
     end
 
-    # Fixes double sided faces in DAE file to import.
-    def fix_faces_in_dae_import
-      dae_import = File.read(@dae_import_file_path)
-
-      dae_import.insert(0, "<!-- File modified by Universal Importer plugin for SketchUp. -->\n")
-
-      # Thanks to Piotr Rachtan for workaround.
-      # @see https://github.com/SketchUp/api-issue-tracker/issues/414
-      faces_fix = '<extra><technique profile="GOOGLEEARTH">'
-      faces_fix += '<double_sided>1</double_sided>'
-      faces_fix += "</technique></extra>\n</profile_COMMON>"
-
-      dae_import.gsub!('</profile_COMMON>', faces_fix)
-
-      File.write(@dae_import_file_path, dae_import)
-    end
-
     # Converts current SketchUp model to SKP format.
     #
     # @return [Boolean]