mm/mm_heap: Add to print size of pending free in heapinfo logs #6762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwakuwaku
reviewed
Apr 10, 2025
|
|
||
| delayfree_resource = 0; | ||
| flags = enter_critical_section(); | ||
| for (int cpu = 0; cpu < CONFIG_SMP_NCPUS; cpu++) { |
There was a problem hiding this comment.
why only this particular code piece is needed to be in critical zone?
There was a problem hiding this comment.
TizenRT/os/mm/mm_heap/mm_malloc.c
Lines 101 to 124 in f669e86
Please refer above code lines.
If mm_heapinfo_parse_heap.c printing is excuting and other core is free delaylist, the information can be wrong or the data abort can be occured.
If the CPU idle state is not present and lpwork is not running, the delayed free operation of sched_free may not function properly. To check this, Add to display the size of any delayed free that has not yet been released in heapinfo command. Signed-off-by: eunwoo.nam <eunwoo.nam@samsung.com>
ewoodev
force-pushed
the
WORK-250410_dump_delay_free
branch
from
8dacc40 to
db5c653
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the CPU idle state is not present and lpwork is not running, the delayed free operation of sched_free may not function properly.
To check this, Add to display the size of any delayed free that has not yet been released in heapinfo command.