binary_manager: Support new APIs for partition swap #6706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongarmy
force-pushed
the
binary_manager
branch
from
7d998d6 to
7e005a4
Compare
1. binary_manager_get_inactive_info_all : Get info of all registered binaries in inactive(non-running) partition 2. binary_manager_swap_partition : Update bootparam data to swap opposite partition if all valid binaries exist in opposite partition
jeongarmy
force-pushed
the
binary_manager
branch
from
7e005a4 to
3104542
Compare
| @@ -59,6 +59,8 @@ binmgr_result_type_e binary_manager_set_request(binmgr_request_t *request_msg, i | |||
| case BINMGR_SETBP: | |||
| request_msg->data.type = *(uint8_t *)arg; | |||
| break; | |||
| case BINMGR_SWAPBP: | |||
There was a problem hiding this comment.
Is this necessary? It looks that default covers.
|
|
||
| binmgr_result_type_e binary_manager_swap_partition(void) | ||
| { | ||
| #ifndef CONFIG_USE_BP |
There was a problem hiding this comment.
How about locating positive case first? Because n could be missing at code checking.
| @@ -125,6 +129,10 @@ enum binmgr_request_msg_type { | |||
| #ifdef CONFIG_BINMGR_RECOVERY | |||
| BINMGR_FAULT, | |||
| #endif | |||
| #ifdef CONFIG_USE_BP | |||
There was a problem hiding this comment.
In enum, I wanna remove conditionals.
Let's return INVALID or NOT SUPPORT when the related config is disabled.
| #ifdef CONFIG_RESOURCE_FS | ||
| /* Update bootparam if valid resource binary exists */ | ||
| ret = binary_manager_check_resource_update(false); | ||
| if (ret < 0) { |
There was a problem hiding this comment.
When we get failure at somewhere, kernel update or resource update or user update, can we know which gets failure?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binary_manager_get_inactive_info_all : Get info of all registered binaries in inactive(non-running) partition
binary_manager_swap_partition : Update bootparam data to swap opposite partition if all valid binaries exist in opposite partition