os/board/rtl8730e/src/component: Add critical section in GDMA channel… #6705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… allocate 1. In SMP, the same channel might be allocated to both cores if they are access it simultaneously 2. add critical section to ensure only one core can access at one time
| @@ -730,7 +730,9 @@ GDMA_ChnlAlloc(u32 GDMA_Index, IRQ_FUN IrqFun, u32 IrqData, u32 IrqPriority) | |||
| u8 ValTemp = 0; | |||
|
|
|||
| assert_param(IS_GDMA_Index(GDMA_Index)); | |||
|
|
|||
| #ifdef CONFIG_SMP | |||
| irqstate_t flags = enter_critical_section(); | |||
There was a problem hiding this comment.
- Is this required enter_critical_section? not dma lock like sem or mutex?
- Is there any issue from this?
There was a problem hiding this comment.
- I think mutex/sem should also be fine, the purpose is to prevent multi-core accessing this at the same time. Let me think about how to modify it.
- GDMA channel is not dedicated to each peripheral, so it will search for available channel and allocate it to the respective peripheral during initialization. There is a chance where multi core access, the same free channel is allocatecd to different peripherals and this will cause issue.
There was a problem hiding this comment.
Hi @sunghan-chang ,
After discussion, I still think enter_critical_section should be used, because channel allocate/free might be called in ISR, so sem or mutex shouldnt be used..
|
@zhongnuo-tang Could you let us know how verify (test)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… allocate