Skip to content

[Tizen.Applications] Modification of critical section logic of lifecycle event processing queue #7369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Hyeon-Uk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Tizen.Applications] Modification of critical section logic of lifecycle event processing queue #7369

Hyeon-Uk wants to merge 2 commits into from

Conversation

@Hyeon-Uk
Copy link
Contributor

@Hyeon-Uk Hyeon-Uk commented Dec 12, 2025

Description of Change

  • Change critical section flag to lock.
  • set the function to exit immediately when the lock acquisition attempt fails.
  • Add finally block to release lock.

API Changes

  • ACR: N/A

@github-actions github-actions bot added the API14 Platform : Tizen 11.0 / TFM: net8.0-tizen11.0 label Dec 12, 2025
@upple upple requested a review from newb1e-kim December 12, 2025 01:05
upple
upple approved these changes Dec 12, 2025
View reviewed changes
Copy link
Collaborator

@upple upple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Hyeon-Uk Hyeon-Uk changed the title [Tizen.Applications] Modification of critical interval logic of lifecycle event processing queue [Tizen.Applications] Modification of critical section logic of lifecycle event processing queue Dec 12, 2025
upple
upple approved these changes Dec 12, 2025
View reviewed changes
Copy link
Collaborator

@upple upple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please prepare this PR to API13 branch as well.

@Hyeon-Uk @upple
Fix the starvation of lifecycle event
e701777 
If the lifecycle event throws an exception, the ProcessLifecycleEvent function
is terminated without changing the Critical Section Flag(__processing)

Since then, we can not run any other lifecycle events that come in.

So, even if exception is thrown, flag can be changed through finally,
and lock is used rather than flag value for concurrency.

Signed-off-by: Hyeon-Uk <rlagusdnr120@gmail.com>
@Hyeon-Uk @upple
Remove retry logic
d460a32 
Signed-off-by: Hyeon-Uk <rlagusdnr120@gmail.com>
@upple upple force-pushed the fix/lifecycle-starvation branch from 95566f1 to d460a32 Compare December 12, 2025 06:50
newb1e-kim
newb1e-kim approved these changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@newb1e-kim newb1e-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

elishateng
elishateng approved these changes Dec 22, 2025
View reviewed changes
Copy link
Contributor

@elishateng elishateng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@upple upple upple approved these changes

@elishateng elishateng elishateng approved these changes

@newb1e-kim newb1e-kim newb1e-kim approved these changes

Assignees

No one assigned

Labels

API14 Platform : Tizen 11.0 / TFM: net8.0-tizen11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hyeon-Uk @upple @elishateng @newb1e-kim