Skip to content

[NUI.Samples] Change corner radius source name as "ViewCornerRadius" #6842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

hinohie
Copy link
Contributor

@hinohie hinohie commented Apr 15, 2025

Their was conflict issue in dali side, both DecoratedVisualRenderer and Control has same name as animatable.

To fix this issue, we should seperate the name as unique.

After now, we sould access to View's CornerRadius by string "viewCornerRadius".

Relative dali patch:
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-toolkit/+/322738

Their was conflict issue in dali side, both DecoratedVisualRenderer and
Control has same name as animatable.

To fix this issue, we should seperate the name as unique.

After now, we sould access to View's CornerRadius by string "viewCornerRadius".

Relative dali patch:
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-toolkit/+/322738

Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Copy link
Contributor

@jmmhappy jmmhappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@tscholb tscholb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@hinohie hinohie merged commit 05cf985 into Samsung:DevelNUI Apr 16, 2025
3 checks passed
@hinohie hinohie deleted the change_source_name branch April 16, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants