Skip to content

[NUI] Remove DALi instance from Size2D #6728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

[NUI] Remove DALi instance from Size2D #6728

wants to merge 13 commits into from

Conversation

AdunFang
Copy link
Contributor

Description of Change

API Changes

  • ACR:

Eunki, Hong and others added 9 commits March 7, 2025 12:58
@hinohie
[NUI](Rendering) Create Renderer constructor without Geometry and Shader
de51545 
Until now, geometry and shader was mendentory.
But if developper try to derive the class, this give some bad experience.

So let we allow to create renderer without geometry or shader.

Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
@hinohie
[NUI](Rendering) Construct shader with name
2479ef2 
Let we make the name of shader class at C# side.

Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
@huayongxu @dongsug-song
[NUI] Remove boxing/unboxing in RecyclerView, etc.
fc087a6
@huayongxu @dongsug-song
[NUI] Fix some warnings in NUI.
525c614 
1) Return value is not checked.
2) Null parameter is not checked.
@huayongxu @dongsug-song
[NUI] Remove boxing/unboxing in ScrollableBase, etc.
e81ce0f
@everLEEst
Revert "[NUI] add asynchronous tasked animation play"
4187fad 
This reverts commit c9cb592.
@hinohie
[NUI.Samples] Fix compile error after some typo error fix
9a6ac07 
`WidthSdpecification` --> `WidthSpecification`
`HeightSdpecification` --> `HeightSpecification`
`Disdpose()` --> `Dispose()`

Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
@AdunFang @dongsug-song
Add ptr pool
dc11d8a
@AdunFang @dongsug-song
Add API for release IntPtr
18aeab0
dongsug-song
dongsug-song approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@dongsug-song dongsug-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

huayongxu
huayongxu approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@huayongxu huayongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 2, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.Color::Dispose()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.Color::Dispose(System.Boolean)

@dongsug-song dongsug-song changed the title Remove DALi instance from Size2D [NUI] Remove DALi instance from Size2D Mar 14, 2025
@dongsug-song
Copy link
Contributor

@AdunFang
Hello, please add the description of this PR.
also please add sample code or sample app to verify this patch.
if this is an WIP patch, please convert this PR to "draft".
thank you.

1 similar comment
@dongsug-song
Copy link
Contributor

@AdunFang
Hello, please add the description of this PR.
also please add sample code or sample app to verify this patch.
if this is an WIP patch, please convert this PR to "draft".
thank you.

@dongsug-song
Copy link
Contributor

@AdunFang
Hello, please add the description of this PR.
also please add sample code or sample app to verify this patch.
if this is an WIP patch, please convert this PR to "draft".
thank you.

@dongsug-song dongsug-song requested a review from bshsqa as a code owner April 10, 2025 05:53
@dongsug-song
Copy link
Contributor

Hello, There was a diff and conflict between DevelNUI and main, causing difficulties in integrating NUI. Therefore, a hard reset was performed on DevelNUI. As a result, the pull requests (https://github.com/Samsung/TizenFX/pulls) in DevelNUI are now conflicting. To resolve this, you can go to the specific PR, where you will see an error indicating a conflict. You can then use the command line to resolve the conflict.
or Here is another example. This one updates everything below the topmost patch, leaving only the topmost patch unchanged.

git fetch upstream
git rebase --onto=upstream/DevelNUI HEAD~1
git push {current working branch} -f

I'm sorry for the inconvenience.
thank you.

@dongsug-song
Copy link
Contributor

No response and no patch updates, so closing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongsug-song dongsug-song dongsug-song approved these changes

@huayongxu huayongxu huayongxu approved these changes

@Seoyeon2Kim Seoyeon2Kim Awaiting requested review from Seoyeon2Kim

@taehyub taehyub Awaiting requested review from taehyub

@jaehyun0cho jaehyun0cho Awaiting requested review from jaehyun0cho

@everLEEst everLEEst Awaiting requested review from everLEEst

@rabbitfor rabbitfor Awaiting requested review from rabbitfor

@bshsqa bshsqa Awaiting requested review from bshsqa bshsqa is a code owner

Assignees
No one assigned
Labels
Devel-NUI Internal API Changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AdunFang @TizenAPI-Bot @dongsug-song @huayongxu @everLEEst @sparrow74