Skip to content

NTLM token, Similarity filter update, Pattern for base64 filter update#789

Merged
babenek merged 7 commits intoSamsung:mainfrom
babenek:similarity
Dec 1, 2025
Merged

NTLM token, Similarity filter update, Pattern for base64 filter update#789
babenek merged 7 commits intoSamsung:mainfrom
babenek:similarity

Conversation

@babenek
Copy link
Contributor

@babenek babenek commented Nov 28, 2025

Description

Please include a summary of the change and which is fixed.

  • Add NTLM token pattern
  • Fix ValuePatternCheck to skip 0x00 or 0xFF sequences in base64 values
  • Fix ValueAllowlistCheck to match a value starts with $
  • Fix ValueSimilarityCheck to 75% similarity with SequenceMatcher

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.26%. Comparing base (c126863) to head (67cb1d7).

Files with missing lines Patch % Lines
credsweeper/filters/value_similarity_check.py 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #789      +/-   ##
==========================================
- Coverage   92.26%   92.26%   -0.01%     
==========================================
  Files         141      141              
  Lines        5704     5713       +9     
  Branches      925      929       +4     
==========================================
+ Hits         5263     5271       +8     
  Misses        286      286              
- Partials      155      156       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@babenek babenek marked this pull request as ready for review November 28, 2025 13:31
@babenek babenek requested a review from a team as a code owner November 28, 2025 13:31
@babenek babenek marked this pull request as draft November 30, 2025 08:45
@babenek babenek marked this pull request as ready for review December 1, 2025 08:04
Copy link
Collaborator

@Pomidorry Pomidorry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek merged commit 2baf759 into Samsung:main Dec 1, 2025
23 checks passed
@babenek babenek deleted the similarity branch December 1, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants